gitlab-org--gitlab-foss/spec/controllers
Stan Hu 88f2e9615c
Alias GitHub and BitBucket OAuth2 callback URLs
To prevent an OAuth2 covert redirect vulnerability, this commit adds and
uses an alias for the GitHub and BitBucket OAuth2 callback URLs to the
following paths:

GitHub: /users/auth/-/import/github
Bitbucket: /users/auth/-/import/bitbucket

This allows admins to put a more restrictive callback URL in the OAuth2
configuration settings. Instead of https://example.com, admins can now use:

https://example.com/users/auth

It's possible but not trivial to change Devise and OmniAuth to use a
different prefix for callback URLs instead of /users/auth. For now,
aliasing the import URLs under the /users/auth namespace should suffice.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56663
2019-01-31 16:52:48 +01:00
..
admin
boards Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
concerns Save sorting preference for Issues/MRs in BE 2019-01-28 12:48:05 -06:00
dashboard Adds milestone search 2019-01-24 18:44:09 +01:00
explore
google_api
groups Merge branch '54905-milestone-search' into 'master' 2019-01-25 13:22:34 +00:00
import Alias GitHub and BitBucket OAuth2 callback URLs 2019-01-31 16:52:48 +01:00
instance_statistics
ldap
oauth
profiles Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
projects Use common error for unauthenticated users 2019-01-31 16:51:17 +01:00
snippets
users
abuse_reports_controller_spec.rb
application_controller_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
autocomplete_controller_spec.rb
dashboard_controller_spec.rb
graphql_controller_spec.rb
groups_controller_spec.rb
health_check_controller_spec.rb
health_controller_spec.rb
help_controller_spec.rb
invites_controller_spec.rb
metrics_controller_spec.rb
notification_settings_controller_spec.rb
omniauth_callbacks_controller_spec.rb Update gitlab-styles to 2.5.1 2019-01-11 23:59:35 +01:00
passwords_controller_spec.rb
profiles_controller_spec.rb
projects_controller_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
registrations_controller_spec.rb
root_controller_spec.rb
search_controller_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
sent_notifications_controller_spec.rb
sessions_controller_spec.rb
snippets_controller_spec.rb
uploads_controller_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
user_callouts_controller_spec.rb
users_controller_spec.rb Fix contributed projects finder shown private info 2019-01-31 16:51:16 +01:00