f6c7e38040
Previously submitting a DELETE request to an issuable URL would be enough to destroy it, but this should require human confirmation. We now require that the `destroy_confirm` parameter is set to a truthy value before this can complete. In addition, we log a Sentry error if a deletion arrived without confirmation. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62387
91 lines
2.3 KiB
Vue
91 lines
2.3 KiB
Vue
<script>
|
|
/* eslint-disable @gitlab/vue-i18n/no-bare-strings */
|
|
import { __, sprintf } from '~/locale';
|
|
import updateMixin from '../mixins/update';
|
|
import eventHub from '../event_hub';
|
|
|
|
const issuableTypes = {
|
|
issue: __('Issue'),
|
|
epic: __('Epic'),
|
|
};
|
|
|
|
export default {
|
|
mixins: [updateMixin],
|
|
props: {
|
|
canDestroy: {
|
|
type: Boolean,
|
|
required: true,
|
|
},
|
|
formState: {
|
|
type: Object,
|
|
required: true,
|
|
},
|
|
showDeleteButton: {
|
|
type: Boolean,
|
|
required: false,
|
|
default: true,
|
|
},
|
|
issuableType: {
|
|
type: String,
|
|
required: true,
|
|
},
|
|
},
|
|
data() {
|
|
return {
|
|
deleteLoading: false,
|
|
};
|
|
},
|
|
computed: {
|
|
isSubmitEnabled() {
|
|
return this.formState.title.trim() !== '';
|
|
},
|
|
shouldShowDeleteButton() {
|
|
return this.canDestroy && this.showDeleteButton;
|
|
},
|
|
},
|
|
methods: {
|
|
closeForm() {
|
|
eventHub.$emit('close.form');
|
|
},
|
|
deleteIssuable() {
|
|
const confirmMessage = sprintf(__('%{issuableType} will be removed! Are you sure?'), {
|
|
issuableType: issuableTypes[this.issuableType],
|
|
});
|
|
// eslint-disable-next-line no-alert
|
|
if (window.confirm(confirmMessage)) {
|
|
this.deleteLoading = true;
|
|
|
|
eventHub.$emit('delete.issuable', { destroy_confirm: true });
|
|
}
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div class="prepend-top-default append-bottom-default clearfix">
|
|
<button
|
|
:class="{ disabled: formState.updateLoading || !isSubmitEnabled }"
|
|
:disabled="formState.updateLoading || !isSubmitEnabled"
|
|
class="btn btn-success float-left qa-save-button"
|
|
type="submit"
|
|
@click.prevent="updateIssuable"
|
|
>
|
|
Save changes
|
|
<i v-if="formState.updateLoading" class="fa fa-spinner fa-spin" aria-hidden="true"> </i>
|
|
</button>
|
|
<button class="btn btn-default float-right" type="button" @click="closeForm">
|
|
{{ __('Cancel') }}
|
|
</button>
|
|
<button
|
|
v-if="shouldShowDeleteButton"
|
|
:class="{ disabled: deleteLoading }"
|
|
:disabled="deleteLoading"
|
|
class="btn btn-danger float-right append-right-default qa-delete-button"
|
|
type="button"
|
|
@click="deleteIssuable"
|
|
>
|
|
Delete <i v-if="deleteLoading" class="fa fa-spinner fa-spin" aria-hidden="true"> </i>
|
|
</button>
|
|
</div>
|
|
</template>
|