b123171d3d
- Add `avatar_url`, `description`, `git_ssh_url`, `git_http_url`, `path_with_namespace` and `default_branch` in `project` in push, issue, merge-request and note webhooks data - Deprecate the `ssh_url` in favor of `git_ssh_url` and `http_url` in favor of `git_http_url` in `project` for push, issue, merge-request and note webhooks data - Deprecate the `repository` key in push, issue, merge-request and note webhooks data, use `project` instead
95 lines
3.8 KiB
Ruby
95 lines
3.8 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'Gitlab::NoteDataBuilder', lib: true do
|
|
let(:project) { create(:project) }
|
|
let(:user) { create(:user) }
|
|
let(:data) { Gitlab::NoteDataBuilder.build(note, user) }
|
|
let(:note_url) { Gitlab::UrlBuilder.new(:note).build(note.id) }
|
|
let(:fixed_time) { Time.at(1425600000) } # Avoid time precision errors
|
|
|
|
before(:each) do
|
|
expect(data).to have_key(:object_attributes)
|
|
expect(data[:object_attributes]).to have_key(:url)
|
|
expect(data[:object_attributes][:url]).to eq(note_url)
|
|
expect(data[:object_kind]).to eq('note')
|
|
expect(data[:user]).to eq(user.hook_attrs)
|
|
end
|
|
|
|
describe 'When asking for a note on commit' do
|
|
let(:note) { create(:note_on_commit, project: project) }
|
|
|
|
it 'returns the note and commit-specific data' do
|
|
expect(data).to have_key(:commit)
|
|
end
|
|
|
|
include_examples 'project hook data'
|
|
include_examples 'deprecated repository hook data'
|
|
end
|
|
|
|
describe 'When asking for a note on commit diff' do
|
|
let(:note) { create(:note_on_commit_diff, project: project) }
|
|
|
|
it 'returns the note and commit-specific data' do
|
|
expect(data).to have_key(:commit)
|
|
end
|
|
|
|
include_examples 'project hook data'
|
|
include_examples 'deprecated repository hook data'
|
|
end
|
|
|
|
describe 'When asking for a note on issue' do
|
|
let(:issue) { create(:issue, created_at: fixed_time, updated_at: fixed_time) }
|
|
let(:note) { create(:note_on_issue, noteable_id: issue.id, project: project) }
|
|
|
|
it 'returns the note and issue-specific data' do
|
|
expect(data).to have_key(:issue)
|
|
expect(data[:issue].except('updated_at')).to eq(issue.hook_attrs.except('updated_at'))
|
|
expect(data[:issue]['updated_at']).to be > issue.hook_attrs['updated_at']
|
|
end
|
|
|
|
include_examples 'project hook data'
|
|
include_examples 'deprecated repository hook data'
|
|
end
|
|
|
|
describe 'When asking for a note on merge request' do
|
|
let(:merge_request) { create(:merge_request, created_at: fixed_time, updated_at: fixed_time) }
|
|
let(:note) { create(:note_on_merge_request, noteable_id: merge_request.id, project: project) }
|
|
|
|
it 'returns the note and merge request data' do
|
|
expect(data).to have_key(:merge_request)
|
|
expect(data[:merge_request].except('updated_at')).to eq(merge_request.hook_attrs.except('updated_at'))
|
|
expect(data[:merge_request]['updated_at']).to be > merge_request.hook_attrs['updated_at']
|
|
end
|
|
|
|
include_examples 'project hook data'
|
|
include_examples 'deprecated repository hook data'
|
|
end
|
|
|
|
describe 'When asking for a note on merge request diff' do
|
|
let(:merge_request) { create(:merge_request, created_at: fixed_time, updated_at: fixed_time) }
|
|
let(:note) { create(:note_on_merge_request_diff, noteable_id: merge_request.id, project: project) }
|
|
|
|
it 'returns the note and merge request diff data' do
|
|
expect(data).to have_key(:merge_request)
|
|
expect(data[:merge_request].except('updated_at')).to eq(merge_request.hook_attrs.except('updated_at'))
|
|
expect(data[:merge_request]['updated_at']).to be > merge_request.hook_attrs['updated_at']
|
|
end
|
|
|
|
include_examples 'project hook data'
|
|
include_examples 'deprecated repository hook data'
|
|
end
|
|
|
|
describe 'When asking for a note on project snippet' do
|
|
let!(:snippet) { create(:project_snippet, created_at: fixed_time, updated_at: fixed_time) }
|
|
let!(:note) { create(:note_on_project_snippet, noteable_id: snippet.id, project: project) }
|
|
|
|
it 'returns the note and project snippet data' do
|
|
expect(data).to have_key(:snippet)
|
|
expect(data[:snippet].except('updated_at')).to eq(snippet.hook_attrs.except('updated_at'))
|
|
expect(data[:snippet]['updated_at']).to be > snippet.hook_attrs['updated_at']
|
|
end
|
|
|
|
include_examples 'project hook data'
|
|
include_examples 'deprecated repository hook data'
|
|
end
|
|
end
|