gitlab-org--gitlab-foss/app/controllers/concerns
Stan Hu 384a92b736 Check for valid refs in CommitController before doing anything
Before a 404 would be rendered only after a request to Gitaly would
return with an InvalidArgument error. Now we check that the ref have a
valid format before sending it to Gitaly. In both cases, a 404 is
returned to the user, but this change prevents Gitaly from generating
error noise in production.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1425
2018-12-09 21:56:31 -08:00
..
accepts_pending_invitations.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
authenticates_with_two_factor.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
boards_responses.rb Simplify query and add tests for authorization change 2018-10-26 10:27:25 +08:00
checks_collaboration.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
continue_params.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
controller_with_cross_project_access_check.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
creates_commit.rb Revert "Merge branch 'blackst0ne-update-push-new-merge-request-url' into 'master'" 2018-11-07 13:32:20 +00:00
cycle_analytics_params.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
diff_for_path.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
enforces_two_factor_authentication.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
group_tree.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
hooks_execution.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
internal_redirect.rb Merge branch 'frozen-string-app-controller' into 'master' 2018-09-20 22:53:27 +00:00
invalid_utf8_error_handler.rb Enable even more frozen string in app/controllers 2018-09-25 22:43:49 -07:00
issuable_actions.rb Resolve "Filter discussion (tab) by comments or activity in issues and merge requests" 2018-10-23 09:49:45 +00:00
issuable_collections.rb Merge branch 'move-group-issues-search-cte-up-the-chain' into 'master' 2018-12-07 11:14:21 +00:00
issues_action.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
issues_calendar.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
labels_as_hash.rb Create labels_as_hash_ concern, modify params for method 2018-10-03 09:13:42 -07:00
lfs_request.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
members_presentation.rb Add MembersPreloader to fix ActiveRecord cop 2018-11-02 21:38:58 +00:00
membership_actions.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
merge_requests_action.rb Refactor whitelisting of filter params 2018-11-15 01:12:07 +08:00
milestone_actions.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
notes_actions.rb Merge branch 'security-guest-comments' into 'master' 2018-11-28 19:11:56 -05:00
oauth_applications.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
params_backward_compatibility.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
preview_markdown.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
project_unauthorized.rb Restore 403 functionality for external auth (EE) 2018-11-01 19:37:32 +13:00
renders_blob.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
renders_commits.rb Check for valid refs in CommitController before doing anything 2018-12-09 21:56:31 -08:00
renders_member_access.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
renders_notes.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
repository_settings_redirect.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
requires_whitelisted_monitoring_client.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
routable_actions.rb Restore 403 functionality for external auth (EE) 2018-11-01 19:37:32 +13:00
send_file_upload.rb backport: Always proxy reports downloads 2018-11-07 21:49:45 +01:00
sends_blob.rb Fixed bug with the content disposition with wiki attachments 2018-10-17 15:47:05 +00:00
service_params.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
sessionless_authentication.rb Merge branch 'security-fix-pat-web-access' into 'master' 2018-11-28 19:13:59 -05:00
snippets_actions.rb Add feature flag for workhorse content type calculation 2018-12-06 21:22:39 +00:00
spammable_actions.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
todos_actions.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
toggle_award_emoji.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
toggle_subscription_action.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
uploads_actions.rb Add feature flag for workhorse content type calculation 2018-12-06 21:22:39 +00:00
with_performance_bar.rb Simplify by using Gitlab::SafeRequestStore 2018-09-24 12:11:26 -07:00
workhorse_request.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00