gitlab-org--gitlab-foss/lib/gitlab/diff
Robert Speicher 34c083a184 Merge branch 'rubocop/enable-access-modifiers-cops' into 'master'
Enable Rubocop cops that check access modifiers

## What does this MR do?

This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.

This also fixes existing offenses.

## Why was this MR needed?

Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.

## What are the relevant issue numbers?

See #17478  
Closes #17372 

See merge request !5014
2016-07-29 15:58:09 +00:00
..
diff_refs.rb Add some more code comments. 2016-07-06 19:28:13 -04:00
file.rb Collapsed diffs lines/size don't accumulate to overflow diffs. 2016-07-18 14:43:28 -06:00
highlight.rb Remove duplication, unused methods, and some other style things 2016-07-06 19:29:41 -04:00
inline_diff.rb Fix method visibility in inline diff class 2016-07-19 15:12:14 +02:00
inline_diff_marker.rb Reuse existing SCSS variables 2016-05-18 13:20:46 -05:00
line.rb Extract parts of LegacyDiffNote into DiffOnNote concern and move part of responsibility to other classes 2016-07-06 18:50:59 -04:00
line_code.rb Refactoring inside refactoring. We need to go deeper 2014-09-08 21:54:52 +03:00
line_mapper.rb Add some more code comments. 2016-07-06 19:28:13 -04:00
parallel_diff.rb Add Discussion model to represent MR/diff discussion 2016-07-20 16:18:18 -06:00
parser.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
position.rb Ensure to_json methods take optional argument 2016-07-20 11:14:06 +01:00
position_tracer.rb Add Gitlab::Git::PositionTracer 2016-07-06 18:50:59 -04:00