gitlab-org--gitlab-foss/app
Stan Hu 19f9d99870 Fix 500 errors with legacy appearance logos
Prior to GitLab 9.0, attachments were not tracked the `uploads` table,
so it was possible that the appearance logos were just stored in the
database as a string and mounted via CarrierWave.

https://gitlab.com/gitlab-org/gitlab-ce/issues/29240 implemented in
GitLab 10.3 was supposed to cover populating the `uploads` table for all
attachments, including all the logos from appearances. However, it's
possible that didn't work for logos or the `uploads` entry was orphaned.

GitLab instances that had a customized logo with no associated `uploads`
entry would see Error 500s. The only way to fix this is to delete the
`logo` column from the `appearances` table and re-upload the attachment.

This change makes things more robust by falling back to the original
behavior if the upload is not available.

This is a CE backport of
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9277.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9357
2019-01-23 11:18:00 -08:00
..
assets Merge branch '25569-changing-wording-to-delete-when-referring-to-removing-a-branch' into 'master' 2019-01-23 11:02:22 +00:00
controllers Merge branch 'tz-user-avatar-caching' into 'master' 2019-01-22 15:59:45 +00:00
finders Fix MilestonesFinder to pass relations to scope 2019-01-12 00:05:36 +08:00
graphql Suggests issues when typing title 2018-11-27 15:10:40 +00:00
helpers Add client_detection helper to add browser and plaform flags 2019-01-22 14:07:46 +05:30
mailers Import CSV Backend 2019-01-07 11:16:58 +08:00
models Fix 500 errors with legacy appearance logos 2019-01-23 11:18:00 -08:00
policies Service for calling Sentry issues api 2019-01-09 21:04:27 +00:00
presenters Merge branch '54167-rename-project-tags-to-project-topics' into 'master' 2019-01-11 08:42:29 +00:00
serializers Resolve "In Merge Request diff screen, master is not a hyperlink" 2019-01-16 13:18:10 +00:00
services Merge branch '25569-changing-wording-to-delete-when-referring-to-removing-a-branch' into 'master' 2019-01-23 11:02:22 +00:00
uploaders Fix 404s with snippet uploads in object storage 2019-01-21 22:13:37 -08:00
validators Add table and model for error tracking settings 2019-01-07 17:55:21 +00:00
views Added btn_class to the dropdown for custom notifications 2019-01-23 13:58:15 +00:00
workers Refactor ExpirePipelineCacheWorker for EE 2019-01-21 14:33:21 +01:00