1ab33b15d1
remove_column should only be used in the up (or change) step of a migration if it's a post-deployment migration. Otherwise there will be downtime due to the ActiveRecord column cache, which we can avoid by using the IgnorableColumn concern in combination with a post-deployment migration.
30 lines
846 B
Ruby
30 lines
846 B
Ruby
require_relative '../../migration_helpers'
|
|
|
|
module RuboCop
|
|
module Cop
|
|
module Migration
|
|
# Cop that checks if remove_column is used in a regular (not
|
|
# post-deployment) migration.
|
|
class RemoveColumn < RuboCop::Cop::Cop
|
|
include MigrationHelpers
|
|
|
|
MSG = '`remove_column` must only be used in post-deployment migrations'.freeze
|
|
|
|
def on_def(node)
|
|
def_method = node.children[0]
|
|
|
|
return unless in_migration?(node) && !in_post_deployment_migration?(node)
|
|
return unless def_method == :change || def_method == :up
|
|
|
|
node.each_descendant(:send) do |send_node|
|
|
send_method = send_node.children[1]
|
|
|
|
if send_method == :remove_column
|
|
add_offense(send_node, :selector)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|