3bf34face4
Replace issue access checks with use of IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR? ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested ### Issue lookup with access check Using `visible_to_user` likely makes these security issues too. See [Code smells](#code-smells). - [x] 🚦 app/finders/notes_finder.rb:15 [`visible_to_user`] - [x] 🚥 app/views/layouts/nav/_project.html.haml:73 [`visible_to_user`] [`.count`] - [x] ✅ app/services/merge_requests/build_service.rb:84 [`issue.try(:confidential?)`] - [x] ✅ lib/api/issues.rb:112 [`visible_to_user`] - CHANGELOG: Prevented API returning issues set to 'Only team members' to everyone - [x] ✅ lib/api/helpers.rb:126 [`can?(current_user, :read_issue, issue)`] Maybe here too? - [x] ✅ lib/gitlab/search_results.rb:53 [`visible_to_user`] ### Previous discussions - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b2ff264eddf9819d7693c14ae213d941494fe2b3_128_126 - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#7b6375270d22f880bdcb085e47b519b426a5c6c7_87_87 See merge request !2031 |
||
|---|---|---|
| .. | ||
| header | ||
| nav | ||
| _bootlint.haml | ||
| _broadcast.html.haml | ||
| _flash.html.haml | ||
| _google_analytics.html.haml | ||
| _head.html.haml | ||
| _init_auto_complete.html.haml | ||
| _page.html.haml | ||
| _page_title.html.haml | ||
| _piwik.html.haml | ||
| _search.html.haml | ||
| admin.html.haml | ||
| application.html.haml | ||
| dashboard.html.haml | ||
| devise.html.haml | ||
| devise_empty.html.haml | ||
| devise_mailer.html.haml | ||
| errors.html.haml | ||
| explore.html.haml | ||
| group.html.haml | ||
| group_settings.html.haml | ||
| help.html.haml | ||
| koding.html.haml | ||
| notify.html.haml | ||
| profile.html.haml | ||
| project.html.haml | ||
| project_settings.html.haml | ||
| search.html.haml | ||
| snippets.html.haml | ||