a5c8a52782
Caching of BroadcastMessage instances has been changed so a cache stays valid as long as the default cache expiration time permits, instead of the cache being expired after 1 minute. When modifying broadcast messages the cache is flushed automatically. To remove the need for performing sequence scans on the "broadcast_messages" table we also add an index on (starts_at, ends_at, id), permitting PostgreSQL to use an index scan to get all necessary data. Finally this commit adds a few NOT NULL constraints to the table to match the Rails validations. Fixes gitlab-org/gitlab-ce#31706
123 lines
3 KiB
Ruby
123 lines
3 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe BroadcastMessage do
|
|
subject { build(:broadcast_message) }
|
|
|
|
it { is_expected.to be_valid }
|
|
|
|
describe 'validations' do
|
|
let(:triplet) { '#000' }
|
|
let(:hex) { '#AABBCC' }
|
|
|
|
it { is_expected.to allow_value(nil).for(:color) }
|
|
it { is_expected.to allow_value(triplet).for(:color) }
|
|
it { is_expected.to allow_value(hex).for(:color) }
|
|
it { is_expected.not_to allow_value('000').for(:color) }
|
|
|
|
it { is_expected.to allow_value(nil).for(:font) }
|
|
it { is_expected.to allow_value(triplet).for(:font) }
|
|
it { is_expected.to allow_value(hex).for(:font) }
|
|
it { is_expected.not_to allow_value('000').for(:font) }
|
|
end
|
|
|
|
describe '.current', :use_clean_rails_memory_store_caching do
|
|
it 'returns message if time match' do
|
|
message = create(:broadcast_message)
|
|
|
|
expect(described_class.current).to include(message)
|
|
end
|
|
|
|
it 'returns multiple messages if time match' do
|
|
message1 = create(:broadcast_message)
|
|
message2 = create(:broadcast_message)
|
|
|
|
expect(described_class.current).to contain_exactly(message1, message2)
|
|
end
|
|
|
|
it 'returns empty list if time not come' do
|
|
create(:broadcast_message, :future)
|
|
|
|
expect(described_class.current).to be_empty
|
|
end
|
|
|
|
it 'returns empty list if time has passed' do
|
|
create(:broadcast_message, :expired)
|
|
|
|
expect(described_class.current).to be_empty
|
|
end
|
|
|
|
it 'caches the output of the query' do
|
|
create(:broadcast_message)
|
|
|
|
expect(described_class).to receive(:where).and_call_original.once
|
|
|
|
2.times { described_class.current }
|
|
end
|
|
end
|
|
|
|
describe '#active?' do
|
|
it 'is truthy when started and not ended' do
|
|
message = build(:broadcast_message)
|
|
|
|
expect(message).to be_active
|
|
end
|
|
|
|
it 'is falsey when ended' do
|
|
message = build(:broadcast_message, :expired)
|
|
|
|
expect(message).not_to be_active
|
|
end
|
|
|
|
it 'is falsey when not started' do
|
|
message = build(:broadcast_message, :future)
|
|
|
|
expect(message).not_to be_active
|
|
end
|
|
end
|
|
|
|
describe '#started?' do
|
|
it 'is truthy when starts_at has passed' do
|
|
message = build(:broadcast_message)
|
|
|
|
travel_to(3.days.from_now) do
|
|
expect(message).to be_started
|
|
end
|
|
end
|
|
|
|
it 'is falsey when starts_at is in the future' do
|
|
message = build(:broadcast_message)
|
|
|
|
travel_to(3.days.ago) do
|
|
expect(message).not_to be_started
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#ended?' do
|
|
it 'is truthy when ends_at has passed' do
|
|
message = build(:broadcast_message)
|
|
|
|
travel_to(3.days.from_now) do
|
|
expect(message).to be_ended
|
|
end
|
|
end
|
|
|
|
it 'is falsey when ends_at is in the future' do
|
|
message = build(:broadcast_message)
|
|
|
|
travel_to(3.days.ago) do
|
|
expect(message).not_to be_ended
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#flush_redis_cache' do
|
|
it 'flushes the Redis cache' do
|
|
message = create(:broadcast_message)
|
|
|
|
expect(Rails.cache).to receive(:delete).with(described_class::CACHE_KEY)
|
|
|
|
message.flush_redis_cache
|
|
end
|
|
end
|
|
end
|