daad7144ec
This refactors the Markdown pipeline so it supports the rendering of multiple documents that may belong to different projects. An example of where this happens is when displaying the event feed of a group. In this case we retrieve events for all projects in the group. Previously we would group events per project and render these chunks separately, but this would result in many SQL queries being executed. By extending the Markdown pipeline to support this out of the box we can drastically reduce the number of SQL queries. To achieve this we introduce a new object to the pipeline: Banzai::RenderContext. This object simply wraps two other objects: an optional Project instance, and an optional User instance. On its own this wouldn't be very helpful, but a RenderContext can also be used to associate HTML documents with specific Project instances. This work is done in Banzai::ObjectRenderer and allows us to reuse as many queries (and results) as possible.
41 lines
1.2 KiB
Ruby
41 lines
1.2 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Banzai::ReferenceParser::MilestoneParser do
|
|
include ReferenceParserHelpers
|
|
|
|
let(:project) { create(:project, :public) }
|
|
let(:user) { create(:user) }
|
|
let(:milestone) { create(:milestone, project: project) }
|
|
subject { described_class.new(Banzai::RenderContext.new(project, user)) }
|
|
let(:link) { empty_html_link }
|
|
|
|
describe '#nodes_visible_to_user' do
|
|
context 'when the link has a data-issue attribute' do
|
|
before do
|
|
link['data-milestone'] = milestone.id.to_s
|
|
end
|
|
|
|
it_behaves_like "referenced feature visibility", "issues", "merge_requests"
|
|
end
|
|
end
|
|
|
|
describe '#referenced_by' do
|
|
describe 'when the link has a data-milestone attribute' do
|
|
context 'using an existing milestone ID' do
|
|
it 'returns an Array of milestones' do
|
|
link['data-milestone'] = milestone.id.to_s
|
|
|
|
expect(subject.referenced_by([link])).to eq([milestone])
|
|
end
|
|
end
|
|
|
|
context 'using a non-existing milestone ID' do
|
|
it 'returns an empty Array' do
|
|
link['data-milestone'] = ''
|
|
|
|
expect(subject.referenced_by([link])).to eq([])
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|