7f00bcb92e
GitLab has a mechanism that allows CI to clone repositories via HTTP even when the HTTP protocol is disabled. This works as expected when a project is private or internal. However, when a project is public CI gets an error message that HTTP is not allowed. This happens because Git only sends auth in a subsequent request after a 401 is returned first. For public projects, GitLab grabs onto that unauthenticated request and sends it through since it recognizes that Guests are ordinarily allowed to access the repository. Later on this leads to a 403 since HTTP protocol is disabled. Fix this by only continuing with unauthenticated requests when HTTP is allowed.
26 lines
833 B
Ruby
26 lines
833 B
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Projects::GitHttpController do
|
|
describe 'HEAD #info_refs' do
|
|
it 'returns 403' do
|
|
project = create(:project, :public, :repository)
|
|
|
|
head :info_refs, params: { namespace_id: project.namespace.to_param, project_id: project.path + '.git' }
|
|
|
|
expect(response.status).to eq(403)
|
|
end
|
|
end
|
|
|
|
describe 'GET #info_refs' do
|
|
it 'returns 401 for unauthenticated requests to public repositories when http protocol is disabled' do
|
|
stub_application_setting(enabled_git_access_protocol: 'ssh')
|
|
project = create(:project, :public, :repository)
|
|
|
|
get :info_refs, params: { service: 'git-upload-pack', namespace_id: project.namespace.to_param, project_id: project.path + '.git' }
|
|
|
|
expect(response.status).to eq(401)
|
|
end
|
|
end
|
|
end
|