History

Bob Van Landuyt 28acd2b087 Hide confidential events in ruby We're filtering the events using `Event#visible_to_user?`. At most we're loading 100 events at once. Pagination is also dealt with in the finder, but the resulting array is wrapped in a `Kaminari.paginate_array` so the API's pagination helpers keep working. We're passing the total count into that paginatable array, which would include confidential events. But we're not disclosing anything.		2018-12-17 18:47:53 +01:00
..
admin	…
autocomplete	Whitelist none method from ActiveRecord::Querying	2018-10-31 15:46:36 -03:00
concerns	Hide confidential events in ruby	2018-12-17 18:47:53 +01:00
projects/serverless	Introduce Knative Serverless Tab	2018-12-06 18:08:49 +00:00
README.md	…
access_requests_finder.rb	…
applications_finder.rb	…
awarded_emoji_finder.rb	…
branches_finder.rb	…
cluster_ancestors_finder.rb	Use finder to decide to show note to user	2018-12-17 09:51:53 +13:00
clusters_finder.rb	Abstract out project out of ClustersController	2018-11-01 19:36:58 +13:00
contributed_projects_finder.rb	…
environments_finder.rb	…
events_finder.rb	Hide confidential events in ruby	2018-12-17 18:47:53 +01:00
fork_projects_finder.rb	…
group_descendants_finder.rb	Fix default sorting for subgroups and projects list	2018-11-14 14:47:09 +01:00
group_finder.rb	…
group_labels_finder.rb	…
group_members_finder.rb	…
group_projects_finder.rb	…
groups_finder.rb	Whitelist none method from ActiveRecord::Querying	2018-10-31 15:46:36 -03:00
issuable_finder.rb	Remove trailing whitespace	2018-12-07 09:11:21 +00:00
issues_finder.rb	Whitelist none method from ActiveRecord::Querying	2018-10-31 15:46:36 -03:00
joined_groups_finder.rb	…
labels_finder.rb	Whitelist none method from ActiveRecord::Querying	2018-10-31 15:46:36 -03:00
license_template_finder.rb	…
members_finder.rb	…
merge_request_target_project_finder.rb	…
merge_requests_finder.rb	…
milestones_finder.rb	Whitelist none method from ActiveRecord::Querying	2018-10-31 15:46:36 -03:00
notes_finder.rb	Resolve "Filter discussion (tab) by comments or activity in issues and merge requests"	2018-10-23 09:49:45 +00:00
pending_todos_finder.rb	…
personal_access_tokens_finder.rb	Remove PersonalAccessTokensFinder#find_by method	2018-11-05 11:36:45 +01:00
personal_projects_finder.rb	…
pipeline_schedules_finder.rb	…
pipelines_finder.rb	Rename project's pipelines relation	2018-12-05 14:39:15 +00:00
projects_finder.rb	Whitelist none method from ActiveRecord::Querying	2018-10-31 15:46:36 -03:00
remote_mirror_finder.rb	Send a notification email on mirror update errors	2018-12-11 23:08:17 -03:00
runner_jobs_finder.rb	…
snippets_finder.rb	Rewrite SnippetsFinder to improve performance	2018-11-05 14:28:29 +01:00
tags_finder.rb	…
template_finder.rb	…
todos_finder.rb	…
union_finder.rb	…
user_finder.rb	…
user_recent_events_finder.rb	…
users_finder.rb	…
users_with_pending_todos_finder.rb	…

README.md

Finders

This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:

class Project
  def issues_for_user_filtered_by(user, filter)
    # A lot of logic not related to project model itself
  end
end

issues = project.issues_for_user_filtered_by(user, params)

Better use this:

issues = IssuesFinder.new(project, user, filter).execute

It will help keep models thiner.