gitlab-org--gitlab-foss/app/controllers/projects
Douwe Maan f3f856029b Merge branch 'fix-slashes-in-wiki-urls' into 'master'
Fix bug where Wiki pages that include a '/' were no longer accessible

### What does this MR do?

This MR fixes a regression that caused Wiki pages that included a '/' to no longer be accessible.

### Are there points in the code the reviewer needs to double check?

Are there cases that `wiki_helper.rb` doesn't handle?

### Why was this MR needed?

The upgrade from Rails v4.1.2 to v4.1.9 (76aad9b76e) caused slashes in a model ID to be escaped automatically. We can no longer use the built-in the URL helpers to generate the links for Wiki pages if we want to maintain support for slashes. There is no option to tell the formatter otherwise:

http://stackoverflow.com/questions/25031791/rails-4-1-2-to-param-escapes-slashes-and-breaks-app

The Rails code in question is here:

https://github.com/rails/rails/blob/4-1-stable/actionpack/lib/action_dispatch/journey/visitors.rb#L159

### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?

#1363

See merge request !502
2015-04-08 16:30:23 +00:00
..
application_controller.rb
avatars_controller.rb Introduce shortcuts for routing helpers 2015-02-25 19:34:16 -08:00
blame_controller.rb Reuse blob object fetched by Gitlab::Git::Blame. 2015-03-13 13:49:27 +01:00
blob_controller.rb Web Editor: save to new branch 2015-02-24 11:43:20 +02:00
branches_controller.rb Use same constant for amount of items per page 2015-03-12 15:37:00 -07:00
commit_controller.rb
commits_controller.rb
compare_controller.rb Merge branch 'master' into rails-4.1.9 2015-02-21 12:55:28 -07:00
deploy_keys_controller.rb Satisfy Rubocop. 2015-03-17 16:00:32 +01:00
forks_controller.rb Merge branch 'master' into rails-4.1.9 2015-02-21 12:55:28 -07:00
graphs_controller.rb Everything from gitlab_git is already UTF-8. 2015-03-13 13:49:27 +01:00
hooks_controller.rb
imports_controller.rb Fixing import redirect loop 2015-03-09 16:36:41 -07:00
issues_controller.rb tests 2015-03-16 21:38:41 +02:00
labels_controller.rb Use same constant for amount of items per page 2015-03-12 15:37:00 -07:00
merge_requests_controller.rb Refactor GitAccess to use instance variables. 2015-03-24 14:11:48 +01:00
milestones_controller.rb Use same constant for amount of items per page 2015-03-12 15:37:00 -07:00
network_controller.rb
notes_controller.rb Fix bug where editing a comment with "+1" or "-1" would cause a server error 2015-03-02 15:26:00 -08:00
project_members_controller.rb Use `project_member` instead of `team_member`. 2015-03-15 13:50:38 +01:00
protected_branches_controller.rb
raw_controller.rb
refs_controller.rb Render a 404 when RefsController#logs_tree gets an HTML request 2015-04-06 23:08:28 -04:00
repositories_controller.rb Add tests. 2015-03-31 13:37:21 +02:00
services_controller.rb Add a service to support external wikis 2015-03-12 19:13:51 +01:00
snippets_controller.rb Enforce restricted visibilities for snippets 2015-03-08 17:57:08 -06:00
tags_controller.rb Move tag deletion to service and execute hooks and services. 2015-03-13 16:07:08 +01:00
tree_controller.rb Merge branch 'master' into rails-4.1.9 2015-02-21 12:55:28 -07:00
uploads_controller.rb
wikis_controller.rb Fix bug where Wiki pages that include a '/' were no longer accessible 2015-04-07 09:10:11 -07:00