f1ae1e39ce
Moving the check out of the general requests, makes sure we don't have any slowdown in the regular requests. To keep the process performing this checks small, the check is still performed inside a unicorn. But that is called from a process running on the same server. Because the checks are now done outside normal request, we can have a simpler failure strategy: The check is now performed in the background every `circuitbreaker_check_interval`. Failures are logged in redis. The failures are reset when the check succeeds. Per check we will try `circuitbreaker_access_retries` times within `circuitbreaker_storage_timeout` seconds. When the number of failures exceeds `circuitbreaker_failure_count_threshold`, we will block access to the storage. After `failure_reset_time` of no checks, we will clear the stored failures. This could happen when the process that performs the checks is not running.
54 lines
1.5 KiB
Ruby
54 lines
1.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::StorageCheck::Response do
|
|
let(:fake_json) do
|
|
{
|
|
check_interval: 42,
|
|
results: [
|
|
{ storage: 'working', success: true },
|
|
{ storage: 'skipped', success: nil },
|
|
{ storage: 'failing', success: false }
|
|
]
|
|
}.to_json
|
|
end
|
|
|
|
let(:fake_http_response) do
|
|
fake_response = instance_double("Excon::Response - Status check")
|
|
allow(fake_response).to receive(:status).and_return(200)
|
|
allow(fake_response).to receive(:body).and_return(fake_json)
|
|
allow(fake_response).to receive(:headers).and_return('Content-Type' => 'application/json')
|
|
|
|
fake_response
|
|
end
|
|
let(:response) { described_class.new(fake_http_response) }
|
|
|
|
describe '#valid?' do
|
|
it 'is valid for a success response with parseable JSON' do
|
|
expect(response).to be_valid
|
|
end
|
|
end
|
|
|
|
describe '#check_interval' do
|
|
it 'returns the result from the JSON' do
|
|
expect(response.check_interval).to eq(42)
|
|
end
|
|
end
|
|
|
|
describe '#responsive_shards' do
|
|
it 'contains the names of working shards' do
|
|
expect(response.responsive_shards).to contain_exactly('working')
|
|
end
|
|
end
|
|
|
|
describe '#skipped_shards' do
|
|
it 'contains the names of skipped shards' do
|
|
expect(response.skipped_shards).to contain_exactly('skipped')
|
|
end
|
|
end
|
|
|
|
describe '#failing_shards' do
|
|
it 'contains the name of failing shards' do
|
|
expect(response.failing_shards).to contain_exactly('failing')
|
|
end
|
|
end
|
|
end
|