gitlab-org--gitlab-foss/app/controllers
Douwe Maan f3f856029b Merge branch 'fix-slashes-in-wiki-urls' into 'master'
Fix bug where Wiki pages that include a '/' were no longer accessible

### What does this MR do?

This MR fixes a regression that caused Wiki pages that included a '/' to no longer be accessible.

### Are there points in the code the reviewer needs to double check?

Are there cases that `wiki_helper.rb` doesn't handle?

### Why was this MR needed?

The upgrade from Rails v4.1.2 to v4.1.9 (76aad9b76e) caused slashes in a model ID to be escaped automatically. We can no longer use the built-in the URL helpers to generate the links for Wiki pages if we want to maintain support for slashes. There is no option to tell the formatter otherwise:

http://stackoverflow.com/questions/25031791/rails-4-1-2-to-param-escapes-slashes-and-breaks-app

The Rails code in question is here:

https://github.com/rails/rails/blob/4-1-stable/actionpack/lib/action_dispatch/journey/visitors.rb#L159

### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?

#1363

See merge request !502
2015-04-08 16:30:23 +00:00
..
admin Support configurable attachment size via Application Settings 2015-04-02 00:04:08 -07:00
dashboard Move group leave action from dashboard/groups to groups/group_members. 2015-03-15 13:52:28 +01:00
explore Use same constant for amount of items per page 2015-03-12 15:37:00 -07:00
groups Move group leave action from dashboard/groups to groups/group_members. 2015-03-15 13:52:28 +01:00
import Allow projects to be imported into namespaces user is master of. 2015-04-06 14:50:43 +02:00
oauth Application admin scaffold 2015-01-17 15:40:09 -08:00
profiles Restyle oauth accounts at profile page and add ability to unlink account 2015-03-21 17:46:00 -07:00
projects Merge branch 'fix-slashes-in-wiki-urls' into 'master' 2015-04-08 16:30:23 +00:00
application_controller.rb Support configurable attachment size via Application Settings 2015-04-02 00:04:08 -07:00
autocomplete_controller.rb Add autocomplete controller 2015-03-26 19:06:19 -07:00
confirmations_controller.rb
dashboard_controller.rb Use same constant for amount of items per page 2015-03-12 15:37:00 -07:00
groups_controller.rb Move group members index from `/members` to `/group_members`. 2015-03-15 13:51:11 +01:00
help_controller.rb Fix and improve help rendering 2015-04-03 11:56:50 +02:00
namespaces_controller.rb Don't leak private group existence by redirecting from namespace controller to group controller. 2015-03-24 15:55:12 +01:00
omniauth_callbacks_controller.rb When add new social account - redirect to accounts page and show notice message 2015-02-08 00:53:31 -08:00
passwords_controller.rb Use ruby 1.9 hash syntax 2015-01-23 17:41:10 -08:00
profiles_controller.rb Merge branch 'user-location' into 'master' 2015-03-21 00:54:03 +00:00
projects_controller.rb Update html-pipeline and emoji 2015-03-11 16:05:01 -07:00
registrations_controller.rb Redirect signup page to signin page. 2015-02-05 15:56:28 +01:00
search_controller.rb Only trigger actual search if a search string is present 2015-03-19 10:50:34 +01:00
sessions_controller.rb
snippets_controller.rb Merge branch 'master' into fix-restricted-visibility 2015-03-14 10:49:11 -06:00
uploads_controller.rb Reject access to group/project avatar if the user doesn't have access. 2015-03-10 17:13:02 +01:00
users_controller.rb Merge branch 'userpage-activity-scroll' 2015-03-23 09:45:40 -07:00