kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/services
History
Douwe Maan 317206300d Merge branch 'configurable-attachment-size' into 'master' 
Support configurable attachment size in Application Settings page

### What does this MR do?

This MR provides the ability to configure the maximum size of an attachment inside a note. A parameter has been added to the Application Settings page.

### Are there points in the code the reviewer needs to double check?

What should be done with the legacy note attachment validation? I added code to make the validation work with the configurable setting. I could see an issue where an admin lowers the limit from 10 megabytes to 5 megabytes, which could cause an existing model to be invalid.

### Why was this MR needed?

We often have attachments that exceed 10 MB, and it would be nice to be able to override the defaults.

### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?

See Issue #1258

### Screenshots

Before:

![Screen_Shot_2015-03-29_at_3.06.53_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/6013a1dbc8cf61a63e93744149937fa0/Screen_Shot_2015-03-29_at_3.06.53_PM.png)

After:

![Screen_Shot_2015-03-29_at_3.12.34_PM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/f3518af7e8653ba40f0a3579456da6ad/Screen_Shot_2015-03-29_at_3.12.34_PM.png)

See merge request !407
 		2015-04-03 08:47:55 +00:00
..
files Use more specific regexes. 2015-03-27 11:09:29 +01:00
issues No magic numbers for issues filtering 2015-03-26 18:56:42 -07:00
merge_requests No magic numbers for issues filtering 2015-03-26 18:56:42 -07:00
milestones
…
notes Added comment notification events to HipChat and Slack services. 2015-03-06 06:54:00 -08:00
oauth2 Rubocop: no trailing newlines 2015-02-02 21:53:27 -08:00
projects Support configurable attachment size via Application Settings 2015-04-02 00:04:08 -07:00
search Adding in snippet search functionality 2014-08-29 15:32:07 -04:00
archive_repository_service.rb Add tests. 2015-03-31 13:37:21 +02:00
base_service.rb Enforce restricted visibilities for snippets 2015-03-08 17:57:08 -06:00
compare_service.rb
…
create_branch_service.rb Ecevute hooks and services when branches are created/deleted through web. 2015-03-13 16:07:02 +01:00
create_snippet_service.rb Enforce restricted visibilities for snippets 2015-03-08 17:57:08 -06:00
create_tag_service.rb Extend push_tag event to include tag message and last commit 2015-03-21 11:25:27 +01:00
delete_branch_service.rb Ecevute hooks and services when branches are created/deleted through web. 2015-03-13 16:07:02 +01:00
delete_tag_service.rb Move tag deletion to service and execute hooks and services. 2015-03-13 16:07:08 +01:00
event_create_service.rb Use PushDataBuilder where applicable. 2015-03-13 16:06:56 +01:00
git_push_service.rb Extend push_tag event to include tag message and last commit 2015-03-21 11:25:27 +01:00
git_tag_push_service.rb Extend push_tag event to include tag message and last commit 2015-03-21 11:25:27 +01:00
gravatar_service.rb Improve application settings and write tests 2015-01-08 09:53:35 -08:00
issuable_base_service.rb Add labels notes 2015-02-08 22:35:41 +06:00
notification_service.rb Fix cross references when usernames, milestones, or project names contain underscores. 2015-03-19 07:07:30 -07:00
system_hooks_service.rb Generate valid json for hooks 2015-03-10 10:07:25 +01:00
test_hook_service.rb Fix test hook and tests 2015-01-12 09:08:25 -08:00
update_snippet_service.rb Enforce restricted visibilities for snippets 2015-03-08 17:57:08 -06:00