8171544b3d
This ensures that SVGs greater than 2 megabytes are not scrubbed and rendered. This in turn prevents requests from timing out due to reading/scrubbing large SVGs potentially taking a lot of time (and memory). The use of 2 megabytes is completely arbitrary. Fixes gitlab-org/gitlab-ce#1435
119 lines
3 KiB
Ruby
119 lines
3 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Blob do
|
|
describe '.decorate' do
|
|
it 'returns NilClass when given nil' do
|
|
expect(described_class.decorate(nil)).to be_nil
|
|
end
|
|
end
|
|
|
|
describe '#svg?' do
|
|
it 'is falsey when not text' do
|
|
git_blob = double(text?: false)
|
|
|
|
expect(described_class.decorate(git_blob)).not_to be_svg
|
|
end
|
|
|
|
it 'is falsey when no language is detected' do
|
|
git_blob = double(text?: true, language: nil)
|
|
|
|
expect(described_class.decorate(git_blob)).not_to be_svg
|
|
end
|
|
|
|
it' is falsey when language is not SVG' do
|
|
git_blob = double(text?: true, language: double(name: 'XML'))
|
|
|
|
expect(described_class.decorate(git_blob)).not_to be_svg
|
|
end
|
|
|
|
it 'is truthy when language is SVG' do
|
|
git_blob = double(text?: true, language: double(name: 'SVG'))
|
|
|
|
expect(described_class.decorate(git_blob)).to be_svg
|
|
end
|
|
end
|
|
|
|
describe '#video?' do
|
|
it 'is falsey with image extension' do
|
|
git_blob = Gitlab::Git::Blob.new(name: 'image.png')
|
|
|
|
expect(described_class.decorate(git_blob)).not_to be_video
|
|
end
|
|
|
|
UploaderHelper::VIDEO_EXT.each do |ext|
|
|
it "is truthy when extension is .#{ext}" do
|
|
git_blob = Gitlab::Git::Blob.new(name: "video.#{ext}")
|
|
|
|
expect(described_class.decorate(git_blob)).to be_video
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#to_partial_path' do
|
|
def stubbed_blob(overrides = {})
|
|
overrides.reverse_merge!(
|
|
image?: false,
|
|
language: nil,
|
|
lfs_pointer?: false,
|
|
svg?: false,
|
|
text?: false
|
|
)
|
|
|
|
described_class.decorate(double).tap do |blob|
|
|
allow(blob).to receive_messages(overrides)
|
|
end
|
|
end
|
|
|
|
it 'handles LFS pointers' do
|
|
blob = stubbed_blob(lfs_pointer?: true)
|
|
|
|
expect(blob.to_partial_path).to eq 'download'
|
|
end
|
|
|
|
it 'handles SVGs' do
|
|
blob = stubbed_blob(text?: true, svg?: true)
|
|
|
|
expect(blob.to_partial_path).to eq 'image'
|
|
end
|
|
|
|
it 'handles images' do
|
|
blob = stubbed_blob(image?: true)
|
|
|
|
expect(blob.to_partial_path).to eq 'image'
|
|
end
|
|
|
|
it 'handles text' do
|
|
blob = stubbed_blob(text?: true)
|
|
|
|
expect(blob.to_partial_path).to eq 'text'
|
|
end
|
|
|
|
it 'defaults to download' do
|
|
blob = stubbed_blob
|
|
|
|
expect(blob.to_partial_path).to eq 'download'
|
|
end
|
|
end
|
|
|
|
describe '#size_within_svg_limits?' do
|
|
let(:blob) { described_class.decorate(double(:blob)) }
|
|
|
|
it 'returns true when the blob size is smaller than the SVG limit' do
|
|
expect(blob).to receive(:size).and_return(42)
|
|
|
|
expect(blob.size_within_svg_limits?).to eq(true)
|
|
end
|
|
|
|
it 'returns true when the blob size is equal to the SVG limit' do
|
|
expect(blob).to receive(:size).and_return(Blob::MAXIMUM_SVG_SIZE)
|
|
|
|
expect(blob.size_within_svg_limits?).to eq(true)
|
|
end
|
|
|
|
it 'returns false when the blob size is larger than the SVG limit' do
|
|
expect(blob).to receive(:size).and_return(1.terabyte)
|
|
|
|
expect(blob.size_within_svg_limits?).to eq(false)
|
|
end
|
|
end
|
|
end
|