6f3c490107
This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder".
39 lines
1,018 B
Ruby
39 lines
1,018 B
Ruby
class AutocompleteController < ApplicationController
|
|
skip_before_action :authenticate_user!, only: [:users, :award_emojis]
|
|
|
|
def users
|
|
project = Autocomplete::ProjectFinder
|
|
.new(current_user, params)
|
|
.execute
|
|
|
|
group = Autocomplete::GroupFinder
|
|
.new(current_user, project, params)
|
|
.execute
|
|
|
|
users = Autocomplete::UsersFinder
|
|
.new(params: params, current_user: current_user, project: project, group: group)
|
|
.execute
|
|
|
|
render json: UserSerializer.new.represent(users)
|
|
end
|
|
|
|
def user
|
|
user = UserFinder.new(params).execute!
|
|
|
|
render json: UserSerializer.new.represent(user)
|
|
end
|
|
|
|
# Displays projects to use for the dropdown when moving a resource from one
|
|
# project to another.
|
|
def projects
|
|
projects = Autocomplete::MoveToProjectFinder
|
|
.new(current_user, params)
|
|
.execute
|
|
|
|
render json: MoveToProjectSerializer.new.represent(projects)
|
|
end
|
|
|
|
def award_emojis
|
|
render json: AwardedEmojiFinder.new(current_user).execute
|
|
end
|
|
end
|