fe5f75930e
[master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request" See merge request gitlab/gitlabhq!2583
67 lines
2.3 KiB
Ruby
67 lines
2.3 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::Auth::RequestAuthenticator do
|
|
let(:env) do
|
|
{
|
|
'rack.input' => '',
|
|
'REQUEST_METHOD' => 'GET'
|
|
}
|
|
end
|
|
let(:request) { ActionDispatch::Request.new(env) }
|
|
|
|
subject { described_class.new(request) }
|
|
|
|
describe '#user' do
|
|
let!(:sessionless_user) { build(:user) }
|
|
let!(:session_user) { build(:user) }
|
|
|
|
it 'returns sessionless user first' do
|
|
allow_any_instance_of(described_class).to receive(:find_sessionless_user).and_return(sessionless_user)
|
|
allow_any_instance_of(described_class).to receive(:find_user_from_warden).and_return(session_user)
|
|
|
|
expect(subject.user([:api])).to eq sessionless_user
|
|
end
|
|
|
|
it 'returns session user if no sessionless user found' do
|
|
allow_any_instance_of(described_class).to receive(:find_user_from_warden).and_return(session_user)
|
|
|
|
expect(subject.user([:api])).to eq session_user
|
|
end
|
|
|
|
it 'returns nil if no user found' do
|
|
expect(subject.user([:api])).to be_blank
|
|
end
|
|
|
|
it 'bubbles up exceptions' do
|
|
allow_any_instance_of(described_class).to receive(:find_user_from_warden).and_raise(Gitlab::Auth::UnauthorizedError)
|
|
end
|
|
end
|
|
|
|
describe '#find_sessionless_user' do
|
|
let!(:access_token_user) { build(:user) }
|
|
let!(:feed_token_user) { build(:user) }
|
|
|
|
it 'returns access_token user first' do
|
|
allow_any_instance_of(described_class).to receive(:find_user_from_web_access_token).and_return(access_token_user)
|
|
allow_any_instance_of(described_class).to receive(:find_user_from_feed_token).and_return(feed_token_user)
|
|
|
|
expect(subject.find_sessionless_user([:api])).to eq access_token_user
|
|
end
|
|
|
|
it 'returns feed_token user if no access_token user found' do
|
|
allow_any_instance_of(described_class).to receive(:find_user_from_feed_token).and_return(feed_token_user)
|
|
|
|
expect(subject.find_sessionless_user([:api])).to eq feed_token_user
|
|
end
|
|
|
|
it 'returns nil if no user found' do
|
|
expect(subject.find_sessionless_user([:api])).to be_blank
|
|
end
|
|
|
|
it 'rescue Gitlab::Auth::AuthenticationError exceptions' do
|
|
allow_any_instance_of(described_class).to receive(:find_user_from_web_access_token).and_raise(Gitlab::Auth::UnauthorizedError)
|
|
|
|
expect(subject.find_sessionless_user([:api])).to be_blank
|
|
end
|
|
end
|
|
end
|