f73193c328
Prior to this commit the refreshing of authorized projects was done in two steps: 1. Remove existing authorizations 2. Insert a new list of all authorizations This can lead to a high amount of dead tuples as every time all rows are being replaced. For example, if a user with 100 authorizations is given access to a new project this would lead to: * 100 rows being removed * 101 new rows being inserted This commit changes the way this system works so it only removes/inserts what is necessary. Using the above example this would lead to only 1 new row being inserted, with the initial 100 being left untouched. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/25257
21 lines
725 B
Ruby
21 lines
725 B
Ruby
class ProjectAuthorization < ActiveRecord::Base
|
|
belongs_to :user
|
|
belongs_to :project
|
|
|
|
validates :project, presence: true
|
|
validates :access_level, inclusion: { in: Gitlab::Access.all_values }, presence: true
|
|
validates :user, uniqueness: { scope: [:project, :access_level] }, presence: true
|
|
|
|
def self.insert_authorizations(rows, per_batch = 1000)
|
|
rows.each_slice(per_batch) do |slice|
|
|
tuples = slice.map do |tuple|
|
|
tuple.map { |value| connection.quote(value) }
|
|
end
|
|
|
|
connection.execute <<-EOF.strip_heredoc
|
|
INSERT INTO project_authorizations (user_id, project_id, access_level)
|
|
VALUES #{tuples.map { |tuple| "(#{tuple.join(', ')})" }.join(', ')}
|
|
EOF
|
|
end
|
|
end
|
|
end
|