gitlab-org--gitlab-foss/app
Luke Duncalfe 23a462879f Handle blank projects in CommitCollection#enrich!
A project is needed in order to fetch data from gitaly. Projects can be
absent from commits in certain rare situations (like when viewing a MR
of a deleted fork). In these cases, assume that the enriched data is not
needed.

See this comment:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26144#note_152191106

"It's led to a dilemma about where to "fix" this in code. I'm going
to fix it by allowing CommitCollection#enrich! to just return unenriched
commits when a project is missing, essentially "silently failing". I
hope this is the right decision. It's going with the assumption that
calls in these situations in the future are not needing the full data.
The alternative would be to allow CommitCollection#enrich! to still
error, but handle it in the methods that call #enrich!, however that
might lead to brittleness in future when working with project-less MRs."
2019-03-22 10:26:16 +13:00
..
assets Merge branch 'sh-fix-ssh-pull-mirorrs-ce' into 'master' 2019-03-19 14:19:38 +00:00
controllers Reject HEAD requests to info/refs endpoint 2019-03-19 11:23:51 -07:00
finders Only count active milestones as started 2019-03-19 14:28:30 +00:00
graphql Add metadata about the GitLab server to GraphQL 2019-03-05 15:00:32 +00:00
helpers add feature flag for users search 2019-03-14 18:30:30 +01:00
mailers Merge branch 'merge-dev-to-master' into 'master' 2019-03-05 10:28:59 +00:00
models Handle blank projects in CommitCollection#enrich! 2019-03-22 10:26:16 +13:00
policies Update group policy to reflect all the requirements 2019-03-13 13:24:03 +00:00
presenters Update pipeline detail view to accommodate post-merge pipelines 2019-03-19 23:19:27 +07:00
serializers Update pipeline detail view to accommodate post-merge pipelines 2019-03-19 23:19:27 +07:00
services Merge branch 'fix/registry2.7-delete-auth' into 'master' 2019-03-19 13:26:17 +00:00
uploaders
validators Fix Bitbucket import 2019-03-14 10:05:17 +00:00
views Merge branch 'nfriend-update-pipeline-detail-view' into 'master' 2019-03-19 20:34:05 +00:00
workers Run rubocop -a 2019-03-13 13:42:43 +00:00