gitlab-org--gitlab-foss/app
Alfredo Sumaran 3a8a7c1251 Merge branch 'fix-invalid-filename-eslint' into 'master'
eslint: Fix invalid filename validation

Attempt to fix the following error which is appearing in every new MR since `eslint-plugin-filenames` was introduced.

```
/builds/gitlab-org/gitlab-ce/app/assets/javascripts/gl_field_error.js.es6
  2:1  error  Filename 'gl_field_error.js.es6' does not match the naming convention  filenames/match-regex
```

This was happening because our ES6 files have the following structure `gl_hello_world.js.es6`. So `eslint-plugin-filenames` was considering as base name `gl_hello_world.js` which didn't pass the previous regex `^[a-z_]+$`

This new regex allows the following filenames to pass as valid:

- `gl_hello_world.js.es6` which base name translates to `gl_hello_world.js` 
-  `gl_foo_bar.js` which base name translates to `gl_foo_bar`
-  `d3.js` which base name translates to `d3` (especial case, maybe we should move this to the vendor dir and make the regex more specific)

See merge request !7281
2016-11-04 03:53:17 +00:00
..
assets Merge branch 'fix-invalid-filename-eslint' into 'master' 2016-11-04 03:53:17 +00:00
controllers Merge branch 'Allow-admin-to-search-for-user-by-secondary-email-address' into 'master' 2016-11-01 16:14:22 +00:00
finders Skip authorization check when searching for labels on IssuableFinder 2016-10-31 23:27:49 -02:00
helpers Merge branch '22914-mini-graph-icons' into 'master' 2016-11-03 22:28:47 +00:00
mailers Just show the first merge request we found, feedback: 2016-10-14 19:54:51 +08:00
models Ensure merge request's "remove branch" accessors return booleans 2016-11-03 18:29:00 +01:00
policies Allow owners to fetch source code in CI builds 2016-11-01 09:37:20 +01:00
services Merge branch '22448-fix-500-nonexisting-branch' into 'master' 2016-11-01 16:52:25 +00:00
uploaders
validators Add robots.txt to the list of reserved namespaces 2016-10-11 02:58:26 +01:00
views Merge branch '22914-mini-graph-icons' into 'master' 2016-11-03 22:28:47 +00:00
workers remove extra spaces from app/workers/post_receive.rb 2016-11-01 21:46:37 +00:00