4e63411daa
Defer saving project services to the database if there are no user changes ## What does this MR do? It defers saving project services to the database as long as it is possible. It creates a project service when creating a project only if this project service has an active template. After that project services are saved on the first edit. ## Are there points in the code the reviewer needs to double check? - tests that used `build_missing_services` before the change - number of queries executed ## Why was this MR needed? Motivation in #22281 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Fixes #22281 See merge request !6958 |
||
---|---|---|
.. | ||
auth | ||
boards | ||
ci | ||
commits | ||
files | ||
groups | ||
issuable | ||
issues | ||
labels | ||
members | ||
merge_requests | ||
milestones | ||
notes | ||
oauth2 | ||
projects | ||
protected_branches | ||
search | ||
slash_commands | ||
wiki_pages | ||
akismet_service.rb | ||
audit_event_service.rb | ||
base_service.rb | ||
compare_service.rb | ||
create_branch_service.rb | ||
create_deployment_service.rb | ||
create_release_service.rb | ||
create_snippet_service.rb | ||
create_tag_service.rb | ||
delete_branch_service.rb | ||
delete_merged_branches_service.rb | ||
delete_tag_service.rb | ||
delete_user_service.rb | ||
destroy_group_service.rb | ||
event_create_service.rb | ||
git_hooks_service.rb | ||
git_push_service.rb | ||
git_tag_push_service.rb | ||
gravatar_service.rb | ||
ham_service.rb | ||
import_export_clean_up_service.rb | ||
issuable_base_service.rb | ||
notification_service.rb | ||
repair_ldap_blocked_user_service.rb | ||
repository_archive_clean_up_service.rb | ||
spam_service.rb | ||
system_hooks_service.rb | ||
system_note_service.rb | ||
test_hook_service.rb | ||
todo_service.rb | ||
update_release_service.rb | ||
update_snippet_service.rb | ||
user_agent_detail_service.rb |