kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/factories
History
Rémy Coutable 3d72cb897e Merge branch '18019-fix-wiki-linking' into 'master' 
Fix wiki linking behavior for markdown wiki pages

Related to #18019 

- As per the documentation in !4372 

## TODO
- [ ] !4432 Have wiki linking behave as per the documentation
    - [x] Move `WikiLinkFilter` specs to the pipeline level
    - [x] Verify current behavior on wiki `show` page
    - [x] Fix current behavior on wiki `show` page
    - [x] Verify current behaviour on wiki preview
    - [x] Fix current behaviour on wiki preview
        - [x] Rewrite all links and get preview links working
        - [x] Make sure all links are on-par with the wiki `show` page
        - [x] TDD `WikiLinkFilter` and get it working
        - [x] Hook `WikiLinkFilter` up
    - [x] Fix tests 
        - [x] Fix `markdown_spec`
        - [x] Fix `wiki` spinach feature
        - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/4f50dd2/builds) to pass
        - [x] Make sure all wiki-related pages are working as expected (history, all pages, etc.)
    - [x] Test in different ruby versions
    - [x] GitLab instances hosted on a relative URL
    - [x] Non-markdown rendering formats?
        - [x] RDoc
        - [x] ASCIIDoc
        - [x] Create issues to fix things for RDoc and ASCIIDoc
    - [x] Gauge performance impact
    - [x] Refactor
    - [x] Re-organize commits
    - [x] Make sure [build](f860e9a8dc/builds) passes
    - [x] Respond to @rymai's comments
        - [x] `class WikiLinkFilter < HTML::Pipeline::Filter`
        - [x] blank line after guard clause
        - [x] keyword arguments for `wiki` and `slug`
        - [x] invert the condition
        - [x] inline `user` in spec
        - [x] Make sure spec names are not out of date
        - [x] Comment for each rewrite rule
    - [x] Add CHANGELOG entry
    - [x] Reorganize commits
    - [x] Make sure [build](19b91e749a/builds) passes
    - [ ] Wait for merge

See merge request !4432
 		2016-06-09 08:37:27 +00:00
..
ci Rename all `[ci_]commit` to `[ci_]pipeline` in specs and features 2016-06-03 16:22:26 +02:00
abuse_reports.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
appearances.rb Branded login page also in CE 2016-02-26 15:50:51 +01:00
award_emoji.rb Incorportate feedback 2016-06-01 12:10:08 +02:00
broadcast_messages.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
commit_statuses.rb Rename all `[ci_]commit` to `[ci_]pipeline` in specs and features 2016-06-03 16:22:26 +02:00
commits.rb Refactor and expose only Gitlab::UrlBuilder.build(record) 2016-04-13 16:07:04 +02:00
deploy_keys_projects.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
emails.rb Remove unused `another_email` factory 2016-03-06 16:34:43 -05:00
events.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
file_uploader.rb Extend specs for GFM uploads rewriter 2016-03-31 09:43:47 +02:00
forked_project_links.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
group_members.rb Replace project_access attribute with access_level in specs and API 2014-09-15 11:36:50 +03:00
groups.rb Improve group visibility level feature 2016-03-18 16:58:04 -03:00
identities.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
issues.rb Restrict access to confidential issues 2016-03-17 20:55:38 -03:00
keys.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
label_links.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
labels.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
lfs_objects.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
lfs_objects_projects.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
merge_requests.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
milestones.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
namespaces.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
notes.rb Merge branch 'master' into awardables 2016-05-30 18:54:08 +02:00
oauth_access_tokens.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
oauth_applications.rb Add spec for deletion of authorized OAuth2 application 2016-04-14 07:24:58 -07:00
personal_snippets.rb Simplify the various Snippet factories 2016-03-08 16:40:27 -05:00
project_group_links.rb Bring ProjectGroupLink model and migrations from EE 2016-03-11 17:47:05 +01:00
project_hooks.rb Backported minimal safewebhook implementation to GitLab CE 2016-04-30 05:04:10 -03:00
project_members.rb Add traits for each access_level to ProjectMember factory 2016-03-06 16:53:22 -05:00
project_snippets.rb Simplify the various Snippet factories 2016-03-08 16:40:27 -05:00
project_wikis.rb Fix wiki tests 2016-04-20 08:25:41 +08:00
projects.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
protected_branches.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
releases.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
sent_notifications.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
service_hooks.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
services.rb Remove unnecessary attribute definitions from Service factory 2016-03-06 16:55:17 -05:00
snippets.rb Simplify the various Snippet factories 2016-03-08 16:40:27 -05:00
spam_logs.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
system_hooks.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
todos.rb Create a todo on failing MR build 2016-05-17 10:17:45 +01:00
u2f_registrations.rb Add a `U2fRegistrations` table/model. 2016-06-06 12:50:31 +05:30
users.rb Add a `U2fRegistrations` table/model. 2016-06-06 12:50:31 +05:30
wiki_pages.rb Implement the correct linking behaviour in `WikiLinkFilter`. 2016-06-09 10:04:15 +05:30