517 lines
16 KiB
Ruby
517 lines
16 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe PostReceive do
|
|
include AfterNextHelpers
|
|
|
|
let(:changes) do
|
|
<<~EOF
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag
|
|
EOF
|
|
end
|
|
|
|
let(:wrongly_encoded_changes) { changes.encode("ISO-8859-1").force_encoding("UTF-8") }
|
|
let(:base64_changes) { Base64.encode64(wrongly_encoded_changes) }
|
|
let(:gl_repository) { "project-#{project.id}" }
|
|
let(:key) { create(:key, user: project.first_owner) }
|
|
let!(:key_id) { key.shell_id }
|
|
|
|
let(:project) do
|
|
create(:project, :repository, auto_cancel_pending_pipelines: 'disabled')
|
|
end
|
|
|
|
let(:job_args) { [gl_repository, key_id, base64_changes] }
|
|
|
|
def perform(changes: base64_changes)
|
|
described_class.new.perform(gl_repository, key_id, changes)
|
|
end
|
|
|
|
context 'as a sidekiq worker' do
|
|
it 'responds to #perform' do
|
|
expect(described_class.new).to respond_to(:perform)
|
|
end
|
|
end
|
|
|
|
context 'with a non-existing project' do
|
|
let(:gl_repository) { "project-123456789" }
|
|
let(:error_message) do
|
|
"Triggered hook for non-existing gl_repository \"#{gl_repository}\""
|
|
end
|
|
|
|
it 'returns false and logs an error' do
|
|
expect(Gitlab::GitLogger).to receive(:error).with("POST-RECEIVE: #{error_message}")
|
|
expect(perform).to be(false)
|
|
end
|
|
|
|
context 'with PersonalSnippet' do
|
|
let(:gl_repository) { "snippet-#{snippet.id}" }
|
|
let(:snippet) { create(:personal_snippet, author: project.first_owner) }
|
|
|
|
it 'does not log an error' do
|
|
expect(Gitlab::GitLogger).not_to receive(:error)
|
|
expect(Gitlab::GitPostReceive).to receive(:new).and_call_original
|
|
expect_next(described_class).to receive(:process_snippet_changes)
|
|
|
|
perform
|
|
end
|
|
end
|
|
|
|
context 'with ProjectSnippet' do
|
|
let(:gl_repository) { "snippet-#{snippet.id}" }
|
|
let(:snippet) { create(:snippet, type: 'ProjectSnippet', project: nil, author: project.first_owner) }
|
|
|
|
it 'returns false and logs an error' do
|
|
expect(Gitlab::GitLogger).to receive(:error).with("POST-RECEIVE: #{error_message}")
|
|
expect(perform).to be(false)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#process_project_changes' do
|
|
context 'with an empty project' do
|
|
let(:empty_project) { create(:project, :empty_repo) }
|
|
|
|
before do
|
|
allow_next(Gitlab::GitPostReceive).to receive(:identify).and_return(empty_project.first_owner)
|
|
# Need to mock here so we can expect calls on project
|
|
allow(Gitlab::GlRepository).to receive(:parse).and_return([empty_project, empty_project, Gitlab::GlRepository::PROJECT])
|
|
end
|
|
|
|
it 'expire the status cache' do
|
|
expect(empty_project.repository).to receive(:expire_status_cache)
|
|
|
|
perform
|
|
end
|
|
|
|
it 'schedules a cache update for commit count and size' do
|
|
expect(ProjectCacheWorker).to receive(:perform_async)
|
|
.with(empty_project.id, [], [:repository_size, :commit_count], true)
|
|
|
|
perform
|
|
end
|
|
end
|
|
|
|
shared_examples 'not updating remote mirrors' do
|
|
it 'does not schedule an update' do
|
|
expect(project).not_to receive(:has_remote_mirror?)
|
|
expect(project).not_to receive(:mark_stuck_remote_mirrors_as_failed!)
|
|
expect(project).not_to receive(:update_remote_mirrors)
|
|
|
|
perform
|
|
end
|
|
end
|
|
|
|
context 'empty changes' do
|
|
it 'does not call any PushService but runs after project hooks' do
|
|
expect(Git::ProcessRefChangesService).not_to receive(:new)
|
|
expect_next(SystemHooksService).to receive(:execute_hooks)
|
|
|
|
perform(changes: "")
|
|
end
|
|
|
|
it_behaves_like 'not updating remote mirrors'
|
|
end
|
|
|
|
context 'unidentified user' do
|
|
let!(:key_id) { "" }
|
|
|
|
it 'returns false' do
|
|
expect(Git::ProcessRefChangesService).not_to receive(:new)
|
|
|
|
expect(perform).to be false
|
|
end
|
|
end
|
|
|
|
context 'with changes' do
|
|
let(:push_service) { double(execute: true) }
|
|
|
|
before do
|
|
allow_next(Gitlab::GitPostReceive).to receive(:identify).and_return(project.first_owner)
|
|
allow(Gitlab::GlRepository).to receive(:parse).and_return([project, project, Gitlab::GlRepository::PROJECT])
|
|
end
|
|
|
|
shared_examples 'updating remote mirrors' do
|
|
it 'schedules an update if the project had mirrors' do
|
|
expect(project).to receive(:has_remote_mirror?).and_return(true)
|
|
expect(project).to receive(:mark_stuck_remote_mirrors_as_failed!)
|
|
expect(project).to receive(:update_remote_mirrors)
|
|
|
|
perform
|
|
end
|
|
end
|
|
|
|
context 'branches' do
|
|
let(:changes) do
|
|
<<~EOF
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést1
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést2
|
|
EOF
|
|
end
|
|
|
|
it 'expires the branches cache' do
|
|
expect(project.repository).to receive(:expire_branches_cache).once
|
|
|
|
perform
|
|
end
|
|
|
|
it 'expires the status cache' do
|
|
expect(project.repository).to receive(:empty?).at_least(:once).and_return(true)
|
|
expect(project.repository).to receive(:expire_status_cache)
|
|
|
|
perform
|
|
end
|
|
|
|
it 'calls Git::ProcessRefChangesService' do
|
|
expect_next(Git::ProcessRefChangesService).to receive(:execute).and_return(true)
|
|
|
|
perform
|
|
end
|
|
|
|
it 'schedules a cache update for repository size only' do
|
|
expect(ProjectCacheWorker).to receive(:perform_async)
|
|
.with(project.id, [], [:repository_size], true)
|
|
|
|
perform
|
|
end
|
|
|
|
it_behaves_like 'updating remote mirrors'
|
|
|
|
context 'with a default branch' do
|
|
let(:changes) do
|
|
<<~EOF
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést1
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést2
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/#{project.default_branch}
|
|
EOF
|
|
end
|
|
|
|
it 'schedules a cache update for commit count and size' do
|
|
expect(ProjectCacheWorker).to receive(:perform_async)
|
|
.with(project.id, [], [:repository_size, :commit_count], true)
|
|
|
|
perform
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'tags' do
|
|
let(:changes) do
|
|
<<~EOF
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag1
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag2
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag3
|
|
EOF
|
|
end
|
|
|
|
before do
|
|
expect(Gitlab::GlRepository).to receive(:parse).and_return([project, project, Gitlab::GlRepository::PROJECT])
|
|
end
|
|
|
|
it 'does not expire branches cache' do
|
|
expect(project.repository).not_to receive(:expire_branches_cache)
|
|
|
|
perform
|
|
end
|
|
|
|
it 'only invalidates tags once' do
|
|
expect(project.repository).to receive(:repository_event).exactly(3).times.with(:push_tag).and_call_original
|
|
expect(project.repository).to receive(:expire_caches_for_tags).once.and_call_original
|
|
expect(project.repository).to receive(:expire_tags_cache).once.and_call_original
|
|
|
|
perform
|
|
end
|
|
|
|
it 'calls Git::ProcessRefChangesService' do
|
|
expect(Git::ProcessRefChangesService).to get_executed
|
|
|
|
perform
|
|
end
|
|
|
|
it 'schedules a single ProjectCacheWorker update' do
|
|
expect(ProjectCacheWorker).to receive(:perform_async)
|
|
.with(project.id, [], [:repository_size], true)
|
|
|
|
perform
|
|
end
|
|
|
|
it_behaves_like 'updating remote mirrors'
|
|
end
|
|
|
|
context 'merge-requests' do
|
|
let(:changes) { "#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/merge-requests/123" }
|
|
|
|
it "does not call any of the services" do
|
|
expect(Git::ProcessRefChangesService).not_to receive(:new)
|
|
|
|
perform
|
|
end
|
|
|
|
it_behaves_like 'not updating remote mirrors'
|
|
end
|
|
|
|
context 'after project changes hooks' do
|
|
let(:fake_hook_data) { { event_name: 'repository_update' } }
|
|
|
|
before do
|
|
allow(Gitlab::DataBuilder::Repository).to receive(:update).and_return(fake_hook_data)
|
|
# silence hooks so we can isolate
|
|
allow_next(Key).to receive(:post_create_hook).and_return(true)
|
|
expect(Git::ProcessRefChangesService).to get_executed
|
|
end
|
|
|
|
it 'calls SystemHooksService' do
|
|
expect_next(SystemHooksService)
|
|
.to receive(:execute_hooks).with(fake_hook_data, :repository_update_hooks)
|
|
.and_return(true)
|
|
|
|
perform
|
|
end
|
|
|
|
it 'increments the usage data counter of pushes event' do
|
|
counter = Gitlab::UsageDataCounters::SourceCodeCounter
|
|
|
|
expect { perform }.to change { counter.read(:pushes) }.by(1)
|
|
end
|
|
|
|
it 'records correct payload with Snowplow event', :snowplow do
|
|
stub_feature_flags(route_hll_to_snowplow_phase2: true)
|
|
|
|
perform
|
|
|
|
expect_snowplow_event(
|
|
category: 'PostReceive',
|
|
action: 'source_code_pushes',
|
|
namespace: project.namespace,
|
|
user: project.first_owner,
|
|
project: project
|
|
)
|
|
end
|
|
|
|
context 'when FF is disabled' do
|
|
before do
|
|
stub_feature_flags(route_hll_to_snowplow_phase2: false)
|
|
end
|
|
|
|
it 'doesnt emit snowplow events', :snowplow do
|
|
perform
|
|
|
|
expect_no_snowplow_event
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'an idempotent worker'
|
|
end
|
|
|
|
describe '#process_wiki_changes' do
|
|
let(:gl_repository) { "wiki-#{project.id}" }
|
|
|
|
before do
|
|
# Need to mock here so we can expect calls on project
|
|
allow(Gitlab::GlRepository).to receive(:parse).and_return([project.wiki, project, Gitlab::GlRepository::WIKI])
|
|
end
|
|
|
|
it 'updates project activity' do
|
|
# Force Project#set_timestamps_for_create to initialize timestamps
|
|
project
|
|
|
|
# MySQL drops milliseconds in the timestamps, so advance at least
|
|
# a second to ensure we see changes.
|
|
travel_to(1.second.from_now) do
|
|
expect do
|
|
perform
|
|
project.reload
|
|
end.to change(project, :last_activity_at)
|
|
.and change(project, :last_repository_updated_at)
|
|
end
|
|
end
|
|
|
|
context 'master' do
|
|
let(:default_branch) { 'master' }
|
|
let(:oldrev) { SeedRepo::Commit::PARENT_ID }
|
|
let(:newrev) { SeedRepo::Commit::ID }
|
|
let(:changes) do
|
|
<<~EOF
|
|
#{oldrev} #{newrev} refs/heads/#{default_branch}
|
|
#{oldrev} #{newrev} refs/heads/tést2
|
|
EOF
|
|
end
|
|
|
|
let(:raw_repo) { double('RawRepo') }
|
|
|
|
it 'processes the changes on the master branch' do
|
|
expect_next(Git::WikiPushService).to receive(:execute)
|
|
|
|
perform
|
|
end
|
|
end
|
|
|
|
context 'branches' do
|
|
let(:changes) do
|
|
<<~EOF
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést1
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést2
|
|
EOF
|
|
end
|
|
|
|
before do
|
|
allow_next(Git::WikiPushService).to receive(:execute)
|
|
end
|
|
|
|
it 'expires the branches cache' do
|
|
expect(project.wiki.repository).to receive(:expire_branches_cache).once
|
|
|
|
perform
|
|
end
|
|
|
|
it 'expires the status cache' do
|
|
expect(project.wiki.repository).to receive(:empty?).and_return(true)
|
|
expect(project.wiki.repository).to receive(:expire_status_cache)
|
|
|
|
perform
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'an idempotent worker'
|
|
end
|
|
|
|
context 'webhook' do
|
|
it 'fetches the correct project' do
|
|
expect(Project).to receive(:find_by).with({ id: project.id })
|
|
|
|
perform
|
|
end
|
|
|
|
it "does not run if the author is not in the project" do
|
|
allow_next(Gitlab::GitPostReceive).to receive(:identify_using_ssh_key).and_return(nil)
|
|
expect(project).not_to receive(:execute_hooks)
|
|
|
|
expect(perform).to be_falsey
|
|
end
|
|
|
|
it 'asks the project to trigger all hooks' do
|
|
create(:project_hook, push_events: true, tag_push_events: true, project: project)
|
|
create(:custom_issue_tracker_integration, push_events: true, merge_requests_events: false, project: project)
|
|
allow(Project).to receive(:find_by).and_return(project)
|
|
|
|
expect(project).to receive(:execute_hooks).twice
|
|
expect(project).to receive(:execute_integrations).twice
|
|
|
|
perform
|
|
end
|
|
|
|
it 'enqueues a UpdateMergeRequestsWorker job' do
|
|
allow(Project).to receive(:find_by).and_return(project)
|
|
expect_next(MergeRequests::PushedBranchesService).to receive(:execute).and_return(%w(tést))
|
|
|
|
expect(UpdateMergeRequestsWorker).to receive(:perform_async).with(project.id, project.first_owner.id, any_args)
|
|
|
|
perform
|
|
end
|
|
end
|
|
|
|
describe '#process_snippet_changes' do
|
|
let(:gl_repository) { "snippet-#{snippet.id}" }
|
|
|
|
before do
|
|
# Need to mock here so we can expect calls on project
|
|
allow(Gitlab::GlRepository).to receive(:parse).and_return([snippet, snippet.project, Gitlab::GlRepository::SNIPPET])
|
|
end
|
|
|
|
shared_examples 'snippet changes actions' do
|
|
context 'unidentified user' do
|
|
let!(:key_id) { '' }
|
|
|
|
it 'returns false' do
|
|
expect(perform).to be false
|
|
end
|
|
end
|
|
|
|
context 'with changes' do
|
|
context 'branches' do
|
|
let(:changes) do
|
|
<<~EOF
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést1
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/heads/tést2
|
|
EOF
|
|
end
|
|
|
|
it 'expires the branches cache' do
|
|
expect(snippet.repository).to receive(:expire_branches_cache).once
|
|
|
|
perform
|
|
end
|
|
|
|
it 'expires the status cache' do
|
|
expect(snippet.repository).to receive(:empty?).at_least(:once).and_return(true)
|
|
expect(snippet.repository).to receive(:expire_status_cache)
|
|
|
|
perform
|
|
end
|
|
|
|
it 'updates snippet statistics' do
|
|
expect(Snippets::UpdateStatisticsService).to receive(:new).with(snippet).and_call_original
|
|
|
|
perform
|
|
end
|
|
end
|
|
|
|
context 'tags' do
|
|
let(:changes) do
|
|
<<~EOF
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag1
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag2
|
|
#{SeedRepo::Commit::PARENT_ID} #{SeedRepo::Commit::ID} refs/tags/tag3
|
|
EOF
|
|
end
|
|
|
|
it 'does not expire branches cache' do
|
|
expect(snippet.repository).not_to receive(:expire_branches_cache)
|
|
|
|
perform
|
|
end
|
|
|
|
it 'only invalidates tags once' do
|
|
expect(snippet.repository).to receive(:expire_caches_for_tags).once.and_call_original
|
|
expect(snippet.repository).to receive(:expire_tags_cache).once.and_call_original
|
|
|
|
perform
|
|
end
|
|
end
|
|
end
|
|
|
|
it_behaves_like 'an idempotent worker'
|
|
end
|
|
|
|
context 'with PersonalSnippet' do
|
|
let!(:snippet) { create(:personal_snippet, :repository, author: project.first_owner) }
|
|
|
|
it_behaves_like 'snippet changes actions'
|
|
end
|
|
|
|
context 'with ProjectSnippet' do
|
|
let!(:snippet) { create(:project_snippet, :repository, project: project, author: project.first_owner) }
|
|
|
|
it_behaves_like 'snippet changes actions'
|
|
end
|
|
end
|
|
|
|
describe 'processing design changes' do
|
|
let(:gl_repository) { "design-#{project.id}" }
|
|
|
|
it 'does not do anything' do
|
|
worker = described_class.new
|
|
|
|
expect(worker).not_to receive(:process_wiki_changes)
|
|
expect(worker).not_to receive(:process_project_changes)
|
|
|
|
described_class.new.perform(gl_repository, key_id, base64_changes)
|
|
end
|
|
|
|
it_behaves_like 'an idempotent worker'
|
|
end
|
|
end
|