7f47dddc25
Clarify blank line rule in newlines_styleguide.md ## What does this MR do? * Corrects a typo in the GitLab Ruby newlines style guide * Makes some vague language in the original guideline more precise ## Are there points in the code the reviewer needs to double check? n/a ## Why was this MR needed? * There was a typo in the original text. * The original text was vague. ## What are the relevant issue numbers? n/a ## Screenshots (if relevant) n/a ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added (Is this recommended for this kind of patch?) - ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - ~~API support added~~ - Tests - ~~Added for this feature/bug~~ - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !6048 |
||
---|---|---|
.. | ||
adding_database_indexes.md | ||
architecture.md | ||
ci_setup.md | ||
code_review.md | ||
db_dump.md | ||
doc_styleguide.md | ||
gitlab_architecture_diagram.png | ||
gitlab_diagram_overview.odg | ||
gotchas.md | ||
instrumentation.md | ||
licensing.md | ||
migration_style_guide.md | ||
newlines_styleguide.md | ||
omnibus.md | ||
performance.md | ||
profiling.md | ||
rake_tasks.md | ||
README.md | ||
scss_styleguide.md | ||
shared_files.md | ||
shell_commands.md | ||
sidekiq_debugging.md | ||
sql.md | ||
testing.md | ||
ui_guide.md | ||
what_requires_downtime.md |
Development
Outside of docs
- CONTRIBUTING.md main contributing guide
- PROCESS.md contributing process
- GitLab Development Kit (GDK) to install a development version
Styleguides
- Documentation styleguide Use this styleguide if you are contributing to documentation.
- SQL Migration Style Guide for creating safe SQL migrations
- Testing standards and style guidelines
- UI guide for building GitLab with existing CSS styles and elements
- SQL guidelines for SQL guidelines
Process
- Code review guidelines for reviewing code and having code reviewed.
Backend howtos
- Architecture of GitLab
- CI setup for testing GitLab
- Gotchas to avoid
- How to dump production data to staging
- Instrumentation
- Performance guidelines
- Rake tasks for development
- Shell commands in the GitLab codebase
- Sidekiq debugging
Databases
Compliance
- Licensing for ensuring license compliance