e8da70e66c
Addressable::URI interprets the `#` in a URI as a URI fragment and does not escape it, but Rails has special helpers that treats these as bona-fide characters that need to be escaped. Closes https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23368
155 lines
4.5 KiB
Ruby
155 lines
4.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe TreeHelper do
|
|
let(:project) { create(:project, :repository) }
|
|
let(:repository) { project.repository }
|
|
let(:sha) { 'c1c67abbaf91f624347bb3ae96eabe3a1b742478' }
|
|
|
|
def create_file(filename)
|
|
project.repository.create_file(
|
|
project.creator,
|
|
filename,
|
|
'test this',
|
|
message: "Automatically created file #{filename}",
|
|
branch_name: 'master'
|
|
)
|
|
end
|
|
|
|
describe '.render_tree' do
|
|
before do
|
|
@id = sha
|
|
@path = ""
|
|
@project = project
|
|
@lfs_blob_ids = []
|
|
end
|
|
|
|
it 'displays all entries without a warning' do
|
|
tree = repository.tree(sha, 'files')
|
|
|
|
html = render_tree(tree)
|
|
|
|
expect(html).not_to have_selector('.tree-truncated-warning')
|
|
end
|
|
|
|
it 'truncates entries and adds a warning' do
|
|
stub_const('TreeHelper::FILE_LIMIT', 1)
|
|
tree = repository.tree(sha, 'files')
|
|
|
|
html = render_tree(tree)
|
|
|
|
expect(html).to have_selector('.tree-truncated-warning', count: 1)
|
|
expect(html).to have_selector('.tree-item-file-name', count: 1)
|
|
end
|
|
end
|
|
|
|
describe '.fast_project_blob_path' do
|
|
it 'generates the same path as project_blob_path' do
|
|
blob_path = repository.tree(sha, 'with space').entries.first.path
|
|
fast_path = fast_project_blob_path(project, blob_path)
|
|
std_path = project_blob_path(project, blob_path)
|
|
|
|
expect(fast_path).to eq(std_path)
|
|
end
|
|
|
|
it 'generates the same path with encoded file names' do
|
|
tree = repository.tree(sha, 'encoding')
|
|
blob_path = tree.entries.find { |entry| entry.path == 'encoding/テスト.txt' }.path
|
|
fast_path = fast_project_blob_path(project, blob_path)
|
|
std_path = project_blob_path(project, blob_path)
|
|
|
|
expect(fast_path).to eq(std_path)
|
|
end
|
|
|
|
it 'respects a configured relative URL' do
|
|
allow(Gitlab.config.gitlab).to receive(:relative_url_root).and_return('/gitlab/root')
|
|
blob_path = repository.tree(sha, '').entries.first.path
|
|
fast_path = fast_project_blob_path(project, blob_path)
|
|
|
|
expect(fast_path).to start_with('/gitlab/root')
|
|
end
|
|
|
|
it 'encodes files starting with #' do
|
|
filename = '#test-file'
|
|
create_file(filename)
|
|
|
|
fast_path = fast_project_blob_path(project, filename)
|
|
|
|
expect(fast_path).to end_with('%23test-file')
|
|
end
|
|
end
|
|
|
|
describe '.fast_project_tree_path' do
|
|
let(:tree_path) { repository.tree(sha, 'with space').path }
|
|
let(:fast_path) { fast_project_tree_path(project, tree_path) }
|
|
let(:std_path) { project_tree_path(project, tree_path) }
|
|
|
|
it 'generates the same path as project_tree_path' do
|
|
expect(fast_path).to eq(std_path)
|
|
end
|
|
|
|
it 'respects a configured relative URL' do
|
|
allow(Gitlab.config.gitlab).to receive(:relative_url_root).and_return('/gitlab/root')
|
|
|
|
expect(fast_path).to start_with('/gitlab/root')
|
|
end
|
|
|
|
it 'encodes files starting with #' do
|
|
filename = '#test-file'
|
|
create_file(filename)
|
|
|
|
fast_path = fast_project_tree_path(project, filename)
|
|
|
|
expect(fast_path).to end_with('%23test-file')
|
|
end
|
|
end
|
|
|
|
describe 'flatten_tree' do
|
|
let(:tree) { repository.tree(sha, 'files') }
|
|
let(:root_path) { 'files' }
|
|
let(:tree_item) { tree.entries.find { |entry| entry.path == path } }
|
|
|
|
subject { flatten_tree(root_path, tree_item) }
|
|
|
|
context "on a directory containing more than one file/directory" do
|
|
let(:path) { 'files/html' }
|
|
|
|
it "returns the directory name" do
|
|
expect(subject).to match('html')
|
|
end
|
|
end
|
|
|
|
context "on a directory containing only one directory" do
|
|
let(:path) { 'files/flat' }
|
|
|
|
it "returns the flattened path" do
|
|
expect(subject).to match('flat/path/correct')
|
|
end
|
|
|
|
context "with a nested root path" do
|
|
let(:root_path) { 'files/flat' }
|
|
|
|
it "returns the flattened path with the root path suffix removed" do
|
|
expect(subject).to match('path/correct')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when the root path contains a plus character' do
|
|
let(:root_path) { 'gtk/C++' }
|
|
let(:tree_item) { double(flat_path: 'gtk/C++/glade') }
|
|
|
|
it 'returns the flattened path' do
|
|
expect(subject).to eq('glade')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#commit_in_single_accessible_branch' do
|
|
it 'escapes HTML from the branch name' do
|
|
helper.instance_variable_set(:@branch_name, "<script>alert('escape me!');</script>")
|
|
escaped_branch_name = '<script>alert('escape me!');</script>'
|
|
|
|
expect(helper.commit_in_single_accessible_branch).to include(escaped_branch_name)
|
|
end
|
|
end
|
|
end
|