gitlab-org--gitlab-foss/app/models/concerns
Robert Speicher 34c083a184 Merge branch 'rubocop/enable-access-modifiers-cops' into 'master'
Enable Rubocop cops that check access modifiers

## What does this MR do?

This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.

This also fixes existing offenses.

## Why was this MR needed?

Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.

## What are the relevant issue numbers?

See #17478  
Closes #17372 

See merge request !5014
2016-07-29 15:58:09 +00:00
..
access_requestable.rb UI and copywriting improvements 2016-06-14 13:18:14 +02:00
awardable.rb Fix not normalized emoji paths 2016-07-14 08:51:00 +02:00
case_sensitivity.rb Revamp finding projects by namespaces 2015-10-08 14:35:32 +02:00
importable.rb started refactoring some stuff based on MR feedback 2016-06-01 18:03:51 +02:00
internal_id.rb Use GitHub Issue/PR number as iid to keep references 2016-04-18 12:15:50 -03:00
issuable.rb Reduce number of queries made for merge_requests/:id/diffs 2016-07-28 16:52:19 +02:00
mentionable.rb Use cattr_accessor instead duplicating code on NoteOnDiff concern 2016-07-15 13:49:16 -03:00
milestoneish.rb Use a better message when milestone is newly created 2016-04-29 10:15:49 +01:00
note_on_diff.rb Add Discussion model to represent MR/diff discussion 2016-07-20 16:18:18 -06:00
participable.rb Use cattr_accessor instead duplicating code on NoteOnDiff concern 2016-07-15 13:49:16 -03:00
referable.rb Fix RangeError exceptions when referring to issues or merge requests outside of max database values 2016-06-18 13:07:38 -07:00
sortable.rb Sort by ID when sorting using "Recently created" 2016-01-07 14:53:02 +01:00
spammable.rb Refactor spam validation to a concern that can be easily reused and improve legibility in SpamCheckService 2016-07-26 19:29:16 -05:00
statuseable.rb Mark builds with manual actions as skipped 2016-07-18 14:48:36 +02:00
strip_attribute.rb Strip attributes for Milestone and Issuable. #3428 2015-11-26 10:16:50 -05:00
subscribable.rb Add API endpoints for un/subscribing from/to a label 2016-05-12 22:48:09 +02:00
taskable.rb Fix bug that happened when replacing the Task list. #2296 2015-11-20 13:58:45 -05:00
token_authenticatable.rb Enable Rubocop cops for invalid access modifiers 2016-07-19 15:12:15 +02:00