253e1818aa
Danger apparently has three different objects which could contain files you often want to check: - git.added_files - git.modified_files - git.renamed_files The problem: If a file is renamed, `modified_files` contains the file path before the rename. In some Danger checks we use `added_files` + `modified_files`, which might contain the deleted paths of renamed files, but missing the new paths of renamed files. So we need to consider `renamed_files` as well.
29 lines
797 B
Ruby
29 lines
797 B
Ruby
# frozen_string_literal: true
|
|
|
|
def get_eslint_files(files)
|
|
files.select do |file|
|
|
file.end_with?('.js', '.vue') &&
|
|
File.read(file).include?('/* eslint-disable')
|
|
end
|
|
end
|
|
|
|
eslint_candidates = get_eslint_files(helper.all_changed_files)
|
|
|
|
return if eslint_candidates.empty?
|
|
|
|
warn 'This merge request changed files with disabled eslint rules. Please consider fixing them.'
|
|
|
|
markdown(<<~MARKDOWN)
|
|
## Disabled eslint rules
|
|
|
|
The following files have disabled `eslint` rules. Please consider fixing them:
|
|
|
|
* #{eslint_candidates.map { |path| "`#{path}`" }.join("\n* ")}
|
|
|
|
Run the following command for more details
|
|
|
|
```
|
|
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \\
|
|
#{eslint_candidates.map { |path| " '#{path}'" }.join(" \\\n")}
|
|
```
|
|
MARKDOWN
|