gitlab-org--gitlab-foss/spec/support
Timothy Andrew eb16e1e3c2 Improve the error message displayed when branch creation fails.
Note: This feature was developed independently on master while this was
in review. I've removed the conflicting bits and left the relevant
additions, mainly a test for `Gitlab::Git::Hook`. The original commit
message follows:

1. `gitlab-shell` outputs errors to `stderr`, but we weren't using this
   information, prior to this commit. Now we capture the `stderr`, and
   display it in the flash message when branch creation fails.

2. This can be used to display better errors for other git operation
   failures with small tweaks.

3. The return value of `Gitlab::Git::Hook#trigger` is changed from a
   simple `true`/`false` to a tuple of `[status, errors]`. All usages
   and tests have been updated to reflect this change.

4. This is only relevant to branch creation _from the Web UI_, since SSH
   and HTTP pushes access `gitlab-shell` either directly or through
   `gitlab-workhorse`.

5. A few minor changes need to be made on the `gitlab-shell` end. Right
   now, the `stderr` message it outputs is prefixed by "GitLab: ", which
   shows up in our flash message. This is better removed.
2016-07-05 11:05:16 +05:30
..
api
gitlab_stubs
import_export
matchers
api_helpers.rb
capybara.rb
capybara_helpers.rb
carrierwave.rb
db_cleaner.rb
email_format_shared_examples.rb
email_helpers.rb
factory_girl.rb
fake_u2f_device.rb
filter_spec_helper.rb
fixture_helpers.rb
import_spec_helper.rb
issue_tracker_service_shared_example.rb
jira_service_helper.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
login_helpers.rb Fixed logout tests 2016-06-28 13:17:29 +01:00
markdown_feature.rb Hook up the updated `WikiLinkFilter` to the wiki controllers. 2016-06-09 10:15:01 +05:30
mentionable_shared_examples.rb
project_hook_data_shared_example.rb
reference_parser_helpers.rb
relative_url.rb
repo_helpers.rb
select2_helper.rb
services_shared_context.rb
setup_builds_storage.rb
stub_configuration.rb
stub_gitlab_calls.rb
stub_gitlab_data.rb
taskable_shared_examples.rb
test_env.rb Improve the error message displayed when branch creation fails. 2016-07-05 11:05:16 +05:30
wait_for_ajax.rb
webmock.rb
workhorse_helpers.rb