gitlab-org--gitlab-foss/app/views/layouts
Annabel Dunstone Gray 12a7e717d7 Merge branch '25743-clean-up-css-for-project-alerts-and-flash-notifications' into 'master'
Resolve "Clean up CSS for project alerts and flash notifications."

## What does this MR do?

Cleans up CSS and html for alert stripes at the top of project pages.

## Screenshots

#### Before:

![Screen_Shot_2016-12-16_at_2.39.01_PM_copy](/uploads/6a700cf1e41557c00cdaef40f6a2a5b2/Screen_Shot_2016-12-16_at_2.39.01_PM_copy.png)

#### After:

![Screen_Shot_2016-12-16_at_2.39.23_PM_copy](/uploads/c849578becc3a634e8b15ab5340d86a2/Screen_Shot_2016-12-16_at_2.39.23_PM_copy.png)

## Are there points in the code the reviewer needs to double check?

In order to get multiple alerts to appear manually while testing, I simply added the following block to [app/views/shared/_no_password.html.haml](app/views/shared/_no_password.html.haml):

```

.no-password-message.alert.alert-warning.hidden-xs
  You won't be able to pull or push project code via #{gitlab_config.protocol.upcase} until you #{link_to 'set a password', edit_profile_password_path} on your account

  .pull-right
    = link_to "Don't show again", profile_path(user: {hide_no_password: true}), method: :put
    |
    = link_to 'Remind later', '#', class: 'hide-no-password-message'

.no-password-message.alert.alert-warning.hidden-xs
  You won't be able to pull or push project code via #{gitlab_config.protocol.upcase} until you #{link_to 'set a password', edit_profile_password_path} on your account

  .pull-right
    = link_to "Don't show again", profile_path(user: {hide_no_password: true}), method: :put
    |
    = link_to 'Remind later', '#', class: 'hide-no-password-message'

.no-password-message.alert.alert-warning.hidden-xs
  You won't be able to pull or push project code via #{gitlab_config.protocol.upcase} until you #{link_to 'set a password', edit_profile_password_path} on your account

  .pull-right
    = link_to "Don't show again", profile_path(user: {hide_no_password: true}), method: :put
    |
    = link_to 'Remind later', '#', class: 'hide-no-password-message'
```


## Why was this MR needed?

More alert-warning stripes are coming via the CI usage limits implementation in EE (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/965), and these layout margins and colors were becoming messy.

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
  - [ ] ~~Added for this feature/bug~~
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Closes #25743

See merge request !8151
2016-12-16 21:50:06 +00:00
..
header Add shortcut for SRs to Skip to content for a11y 2016-11-17 19:41:51 +05:30
nav Merge branch '23305-leave-project-and-leave-group-should-be-buttons' into 'master' 2016-12-09 19:27:09 +00:00
_bootlint.haml Bootlint integration 2015-04-01 21:33:22 +02:00
_broadcast.html.haml Update broadcast_message helper 2016-01-13 11:34:58 -05:00
_flash.html.haml Add flash containers and broadcast messages below subnav 2016-10-01 00:21:37 +03:00
_google_analytics.html.haml
_head.html.haml Removed data-user-is view code 2016-11-25 13:45:34 +01:00
_init_auto_complete.html.haml Changed autocomplete_sources into an action that returns a single 'at' type of sources at a time 2016-12-15 15:20:33 +00:00
_page.html.haml fix margin on alert stripes within ":flash_message" block 2016-12-16 14:30:28 -06:00
_page_title.html.haml
_piwik.html.haml Update piwik template 2015-11-08 18:03:30 +02:00
_search.html.haml 24146 Add focus state to buttons and dropdowns 2016-11-08 10:03:17 -08:00
admin.html.haml Move admin nav to horizontal layout nav 2016-06-15 09:10:16 -05:00
application.html.haml Loads GFM once for per page 2016-10-14 10:52:48 +01:00
dashboard.html.haml Move project header title definition to view in question. 2015-09-17 12:16:24 +02:00
devise.html.haml Add custom text to column 2016-11-03 12:29:41 -05:00
devise_empty.html.haml Render gon data in the page body, not head 2016-06-06 12:50:31 +05:30
devise_mailer.html.haml New confirmation email 🔥 2016-05-25 16:56:06 -04:00
errors.html.haml Fix appearance in error pages 2016-11-29 11:44:07 -07:00
explore.html.haml Clean up overlap between dashboard and explore. 2015-09-08 14:49:20 +01:00
group.html.haml Dont specify sidebar for group and group settings layouts 2016-05-03 12:31:50 +02:00
group_settings.html.haml Dont specify sidebar for group and group settings layouts 2016-05-03 12:31:50 +02:00
help.html.haml Add helpers for header title and sidebar, and move setting those from controllers to layouts. 2015-05-01 10:39:16 +02:00
koding.html.haml Support integration with Koding (online IDE) 2016-08-19 12:10:58 -07:00
notify.html.haml Fix "Unsubscribe" link in notification emails that is triggered by anti-virus 2016-09-20 09:52:57 +02:00
profile.html.haml Implement top navigation concept for profile area 2016-04-19 20:05:30 +02:00
project.html.haml Correctly loads gfm autocomplete source on pages where it is required 2016-09-16 10:49:55 +01:00
project_settings.html.haml Implement new horizontal navigation to project pages 2016-05-16 12:21:12 -05:00
search.html.haml Add helpers for header title and sidebar, and move setting those from controllers to layouts. 2015-05-01 10:39:16 +02:00
snippets.html.haml Clean up overlap between dashboard and explore. 2015-09-08 14:49:20 +01:00