gitlab-org--gitlab-foss/rubocop/cop/gitlab
Yorick Peterse 8a72f5c427
Added FromUnion to easily select from a UNION
This commit adds the module `FromUnion`, which provides the class method
`from_union`. This simplifies the process of selecting data from the
result of a UNION, and reduces the likelihood of making mistakes. As a
result, instead of this:

    union = Gitlab::SQL::Union.new([foo, bar])

    Foo.from("(#{union.to_sql}) #{Foo.table_name}")

We can now write this instead:

    Foo.from_union([foo, bar])

This commit also includes some changes to make this new setup work
properly. For example, a bug in Rails 4
(https://github.com/rails/rails/issues/24193) would break the use of
`from("sub-query-here").includes(:relation)` in certain cases. There was
also a CI query which appeared to repeat a lot of conditions from an
outer query on an inner query, which isn't necessary.

Finally, we include a RuboCop cop to ensure developers use this new
module, instead of using Gitlab::SQL::Union directly.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
2018-09-17 12:39:43 +02:00
..
finder_with_find_by.rb Add a cop for FinderMethods 2018-06-20 18:13:13 +02:00
httparty.rb Merge branch 'fj-15329-services-callbacks-ssrf' into 'security-10-6' 2018-03-21 14:39:21 +00:00
module_with_instance_variables.rb Use gitlab-styles 2017-12-22 08:34:44 -06:00
predicate_memoization.rb Introduce PredicateMemoization cop and fix offenses 2018-01-12 17:54:55 +08:00
union.rb Added FromUnion to easily select from a UNION 2018-09-17 12:39:43 +02:00