b56f093c2b
Add a be_like_time matcher and use it in specs ## What does this MR do? Introduces a be_like_time matcher and refactors existing code to use it ## Are there points in the code the reviewer needs to double check? A few sites use be_within(2.seconds) or 5.minutes - I didn't change those ## Why was this MR needed? A custom matcher helps to document that we need to compare times loosely, and keeps the fudge factor from being declared in multiple places. ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Related to !6935 See merge request !6936 |
||
---|---|---|
.. | ||
repository_check | ||
build_coverage_worker_spec.rb | ||
build_email_worker_spec.rb | ||
build_finished_worker_spec.rb | ||
build_hooks_worker_spec.rb | ||
build_success_worker_spec.rb | ||
delete_user_worker_spec.rb | ||
email_receiver_worker_spec.rb | ||
emails_on_push_worker_spec.rb | ||
expire_build_artifacts_worker_spec.rb | ||
expire_build_instance_artifacts_worker_spec.rb | ||
git_garbage_collect_worker_spec.rb | ||
group_destroy_worker_spec.rb | ||
merge_worker_spec.rb | ||
pipeline_hooks_worker_spec.rb | ||
pipeline_metrics_worker_spec.rb | ||
pipeline_proccess_worker_spec.rb | ||
pipeline_success_worker_spec.rb | ||
pipeline_update_worker_spec.rb | ||
post_receive_spec.rb | ||
project_cache_worker_spec.rb | ||
project_destroy_worker_spec.rb | ||
prune_old_events_worker_spec.rb | ||
remove_expired_group_links_worker_spec.rb | ||
remove_expired_members_worker_spec.rb | ||
repository_fork_worker_spec.rb | ||
repository_import_worker_spec.rb | ||
stuck_ci_builds_worker_spec.rb | ||
trending_projects_worker_spec.rb | ||
update_merge_requests_worker_spec.rb |