gitlab-org--gitlab-foss/spec/helpers
Rémy Coutable 3d72cb897e Merge branch '18019-fix-wiki-linking' into 'master'
Fix wiki linking behavior for markdown wiki pages

Related to #18019 

- As per the documentation in !4372 

## TODO
- [ ] !4432 Have wiki linking behave as per the documentation
    - [x] Move `WikiLinkFilter` specs to the pipeline level
    - [x] Verify current behavior on wiki `show` page
    - [x] Fix current behavior on wiki `show` page
    - [x] Verify current behaviour on wiki preview
    - [x] Fix current behaviour on wiki preview
        - [x] Rewrite all links and get preview links working
        - [x] Make sure all links are on-par with the wiki `show` page
        - [x] TDD `WikiLinkFilter` and get it working
        - [x] Hook `WikiLinkFilter` up
    - [x] Fix tests 
        - [x] Fix `markdown_spec`
        - [x] Fix `wiki` spinach feature
        - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/4f50dd2/builds) to pass
        - [x] Make sure all wiki-related pages are working as expected (history, all pages, etc.)
    - [x] Test in different ruby versions
    - [x] GitLab instances hosted on a relative URL
    - [x] Non-markdown rendering formats?
        - [x] RDoc
        - [x] ASCIIDoc
        - [x] Create issues to fix things for RDoc and ASCIIDoc
    - [x] Gauge performance impact
    - [x] Refactor
    - [x] Re-organize commits
    - [x] Make sure [build](f860e9a8dc/builds) passes
    - [x] Respond to @rymai's comments
        - [x] `class WikiLinkFilter < HTML::Pipeline::Filter`
        - [x] blank line after guard clause
        - [x] keyword arguments for `wiki` and `slug`
        - [x] invert the condition
        - [x] inline `user` in spec
        - [x] Make sure spec names are not out of date
        - [x] Comment for each rewrite rule
    - [x] Add CHANGELOG entry
    - [x] Reorganize commits
    - [x] Make sure [build](19b91e749a/builds) passes
    - [ ] Wait for merge

See merge request !4432
2016-06-09 08:37:27 +00:00
..
application_helper_spec.rb Revert "Merge branch 'avatar-cropping' into 'master' " 2016-03-15 14:55:40 +01:00
auth_helper_spec.rb Enable RSpec/NotToNot cop and auto-correct offenses 2016-05-24 15:40:29 -04:00
blob_helper_spec.rb Update SVG sanitizer to conform to SVG 1.1 2016-05-06 23:20:24 -07:00
broadcast_messages_helper_spec.rb Move BroadcastMessage#status to a helper since it's presentational 2016-01-13 11:49:59 -05:00
ci_status_helper_spec.rb Rename Ci::Commit to Ci::Pipeline and rename some of the ci_commit to pipeline 2016-06-02 16:59:04 +02:00
commits_helper_spec.rb Remove persistent XSS vulnerability in commit_person_link helper 2016-04-17 18:42:49 -04:00
diff_helper_spec.rb Create DiffFilter and change SystemNoteService#change_title to use Gitlab::Diff::InlineDiff 2016-05-18 11:15:10 -05:00
emails_helper_spec.rb Explain reset token expiration in emails 2015-05-16 14:03:07 -06:00
events_helper_spec.rb Clean up EventsHelper spec 2016-05-12 16:52:56 -05:00
form_helper_spec.rb Standardize the way we check for and display form errors 2016-04-04 21:37:07 -04:00
gitlab_markdown_helper_spec.rb Hook up the updated WikiLinkFilter to the wiki controllers. 2016-06-09 10:15:01 +05:30
graph_helper_spec.rb Remove git refs used internally by GitLab from network graph 2015-09-23 08:56:32 -07:00
groups_helper_spec.rb Tweaks, refactoring, and specs 2016-03-20 21:04:07 +01:00
icons_helper_spec.rb
import_helper_spec.rb Fix GitHub project's link on import page when provider has a custom URL 2016-04-19 13:21:30 -03:00
issues_helper_spec.rb Merge branch 'master' into awardables 2016-05-11 08:47:04 +02:00
labels_helper_spec.rb Updated label links to work correctly for filtering 2016-04-26 09:13:03 +01:00
merge_requests_helper_spec.rb Rename Ci::Commit to Ci::Pipeline and rename some of the ci_commit to pipeline 2016-06-02 16:59:04 +02:00
nav_helper_spec.rb
notifications_helper_spec.rb Refactor notification helper and fix notification service 2016-03-30 10:44:20 +02:00
page_layout_helper_spec.rb Don't override issue page description in project layout. 2016-01-06 13:02:51 +01:00
preferences_helper_spec.rb Implementing 'Groups View' and 'TODOs View' as options for dashboard preferences. 2016-03-24 19:59:54 +01:00
projects_helper_spec.rb Merge branch 'rs-backport-ee-372' into 'master' 2016-05-09 14:48:48 +00:00
runners_helper_spec.rb Fix specs 2015-10-14 17:29:18 +02:00
search_helper_spec.rb Fix broken tests 2016-02-04 17:00:32 +01:00
submodule_helper_spec.rb Fix Error 500 when relative submodule resolves to a namespace that has a different name from its path 2015-06-23 05:49:19 -07:00
tab_helper_spec.rb Fix Style/SpaceInsideHashLiteralBraces cop violations 2015-06-22 14:41:00 -04:00
time_helper_spec.rb Refactor CI helpers 2015-09-29 16:26:40 +02:00
tree_helper_spec.rb Fix bad multi-line split from previous commit 2015-06-22 16:06:04 -04:00
visibility_level_helper_spec.rb Improve group visibility level feature 2016-03-18 16:58:04 -03:00