kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/doc/development
History
Douwe Maan bad6d29f33 Merge branch '24059-post-facto-fixups' into 'master' 
Fixups to "Round-robin repository storage"

## What does this MR do?

* Simplifies a method in application_settings.rb
* Correctly marks a migration as needing downtime
* Documents the requirement for renamed columns to be 

## Are there points in the code the reviewer needs to double check?

Should any of these changes be split out? Ideally we'd get this into the same point release as !7273

## Why was this MR needed?

Post-facto review of !7273

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [X] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [X] API support added
- Tests
  - [X] Added for this feature/bug
  - [x] All builds are passing
- [X] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [X] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [X] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Related to #24059

/cc @yorickpeterse @rspeicher

See merge request !7287
 		2016-11-07 11:27:04 +00:00
..
README.md Merge branch 'rs-bin-changelog' into 'master' 2016-11-02 13:25:47 +00:00
adding_database_indexes.md Added documentation on adding database indexes 2016-08-11 14:22:50 +02:00
api_styleguide.md Improve copy 2016-10-17 10:10:13 +02:00
architecture.md Add "GitLab team members only" to diagram link 2016-06-28 03:12:26 +00:00
changelog.md Clarify the author field for the changelog documentation 2016-11-03 18:00:28 +00:00
ci_setup.md Fix dead links in the docs 2016-06-26 12:43:10 +09:00
code_review.md Fix typo and add he MWBS accronym for "Merge When Build Succeeds" 2016-10-07 16:17:28 +02:00
db_dump.md Fix typos in all docs [skip ci] 2015-11-24 02:19:17 +03:00
doc_styleguide.md Change a bunch of doc links to either relative or https://docs.gitlab.com. 2016-11-03 15:11:51 -06:00
frontend.md Fix broken link to observatory cli on Frontend Dev Guide 2016-11-06 22:43:16 -05:00
gitlab_architecture_diagram.png optimize png images losslessly using zopflipng 2016-06-29 19:22:15 +08:00
gitlab_diagram_overview.odg Updated the picture based on comments. 2014-07-10 23:34:29 +02:00
gotchas.md Remove leftover references to coffeescript from comments and docs. 2016-10-31 11:39:52 +01:00
instrumentation.md Document how to track custom events 2016-09-12 17:41:45 +02:00
licensing.md Add OSL to licensing doc 2016-10-31 12:11:56 +00:00
merge_request_performance_guidelines.md Added performance guidelines for new MRs 2016-08-22 14:32:25 +02:00
migration_style_guide.md Link to the "What requires downtime?" page from the Migration Style Guide 2016-10-02 20:36:45 +01:00
newlines_styleguide.md Clarify blank line rule in newlines_styleguide.md 2016-08-26 06:12:30 +00:00
omnibus.md Document fun facts about omnibus-gitlab 2015-02-19 11:20:58 +01:00
performance.md Fix old monitoring links to point to the new location 2016-10-24 16:45:00 +02:00
post_deployment_migrations.md Support for post deployment migrations 2016-10-31 12:54:48 +01:00
profiling.md Updated profiling guides for Sherlock 2015-11-09 14:29:10 +01:00
rake_tasks.md Remove unused `gitlab:generate_docs` Rake task 2016-11-03 17:25:58 +00:00
scss_styleguide.md SCSS Style Guide fixes. 2016-03-23 14:39:12 -06:00
shared_files.md Clarify puppies 2015-10-26 14:28:31 +01:00
shell_commands.md Update Shell Commands doc for configurable git binary path 2015-11-03 17:10:17 -05:00
sidekiq_debugging.md Move sidekiq debug docs to development folder 2014-12-07 01:24:03 +01:00
sidekiq_style_guide.md Re-organize queues to use for Sidekiq 2016-10-21 18:17:07 +02:00
sql.md Added basic SQL guidelines 2016-03-08 11:28:50 +01:00
testing.md Add Rake task to create/repair GitLab Shell hooks symlinks 2016-11-01 14:52:59 -05:00
ui_guide.md Add reference to product map. 2016-08-11 10:11:17 +00:00
what_requires_downtime.md Renaming columns requires downtime 2016-11-07 10:57:08 +00:00

README.md

Development

Outside of docs

Styleguides

Process

Backend howtos

Databases

Compliance