260c8da060
An upcoming update to rubocop-gitlab-security added additional violations.
95 lines
2.4 KiB
Ruby
95 lines
2.4 KiB
Ruby
module IssuableActions
|
|
extend ActiveSupport::Concern
|
|
|
|
included do
|
|
before_action :labels, only: [:show, :new, :edit]
|
|
before_action :authorize_destroy_issuable!, only: :destroy
|
|
before_action :authorize_admin_issuable!, only: :bulk_update
|
|
end
|
|
|
|
def destroy
|
|
issuable.destroy
|
|
destroy_method = "destroy_#{issuable.class.name.underscore}".to_sym
|
|
TodoService.new.public_send(destroy_method, issuable, current_user) # rubocop:disable GitlabSecurity/PublicSend
|
|
|
|
name = issuable.human_class_name
|
|
flash[:notice] = "The #{name} was successfully deleted."
|
|
index_path = polymorphic_path([@project.namespace.becomes(Namespace), @project, issuable.class])
|
|
|
|
respond_to do |format|
|
|
format.html { redirect_to index_path }
|
|
format.json do
|
|
render json: {
|
|
web_url: index_path
|
|
}
|
|
end
|
|
end
|
|
end
|
|
|
|
def bulk_update
|
|
result = Issuable::BulkUpdateService.new(project, current_user, bulk_update_params).execute(resource_name)
|
|
quantity = result[:count]
|
|
|
|
render json: { notice: "#{quantity} #{resource_name.pluralize(quantity)} updated" }
|
|
end
|
|
|
|
private
|
|
|
|
def render_conflict_response
|
|
respond_to do |format|
|
|
format.html do
|
|
@conflict = true
|
|
render :edit
|
|
end
|
|
|
|
format.json do
|
|
render json: {
|
|
errors: [
|
|
"Someone edited this #{issuable.human_class_name} at the same time you did. Please refresh your browser and make sure your changes will not unintentionally remove theirs."
|
|
]
|
|
}, status: 409
|
|
end
|
|
end
|
|
end
|
|
|
|
def labels
|
|
@labels ||= LabelsFinder.new(current_user, project_id: @project.id).execute
|
|
end
|
|
|
|
def authorize_destroy_issuable!
|
|
unless can?(current_user, :"destroy_#{issuable.to_ability_name}", issuable)
|
|
return access_denied!
|
|
end
|
|
end
|
|
|
|
def authorize_admin_issuable!
|
|
unless can?(current_user, :"admin_#{resource_name}", @project)
|
|
return access_denied!
|
|
end
|
|
end
|
|
|
|
def bulk_update_params
|
|
permitted_keys = [
|
|
:issuable_ids,
|
|
:assignee_id,
|
|
:milestone_id,
|
|
:state_event,
|
|
:subscription_event,
|
|
label_ids: [],
|
|
add_label_ids: [],
|
|
remove_label_ids: []
|
|
]
|
|
|
|
if resource_name == 'issue'
|
|
permitted_keys << { assignee_ids: [] }
|
|
else
|
|
permitted_keys.unshift(:assignee_id)
|
|
end
|
|
|
|
params.require(:update).permit(permitted_keys)
|
|
end
|
|
|
|
def resource_name
|
|
@resource_name ||= controller_name.singularize
|
|
end
|
|
end
|