6f3c490107
This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder".
58 lines
1.7 KiB
Ruby
58 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
describe Autocomplete::GroupFinder do
|
|
let(:user) { create(:user) }
|
|
|
|
describe '#execute' do
|
|
context 'with a project' do
|
|
it 'returns nil' do
|
|
project = create(:project)
|
|
|
|
expect(described_class.new(user, project).execute).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'without a group ID' do
|
|
it 'returns nil' do
|
|
expect(described_class.new(user).execute).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'with an empty String as the group ID' do
|
|
it 'returns nil' do
|
|
expect(described_class.new(user, nil, group_id: '').execute).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'without a project and with a group ID' do
|
|
it 'raises ActiveRecord::RecordNotFound if the group does not exist' do
|
|
finder = described_class.new(user, nil, group_id: 1)
|
|
|
|
expect { finder.execute }.to raise_error(ActiveRecord::RecordNotFound)
|
|
end
|
|
|
|
it 'raises ActiveRecord::RecordNotFound if the user can not read the group' do
|
|
group = create(:group, :private)
|
|
finder = described_class.new(user, nil, group_id: group.id)
|
|
|
|
expect { finder.execute }.to raise_error(ActiveRecord::RecordNotFound)
|
|
end
|
|
|
|
it 'raises ActiveRecord::RecordNotFound if an anonymous user can not read the group' do
|
|
group = create(:group, :private)
|
|
finder = described_class.new(nil, nil, group_id: group.id)
|
|
|
|
expect { finder.execute }.to raise_error(ActiveRecord::RecordNotFound)
|
|
end
|
|
|
|
it 'returns the group if it exists and is readable' do
|
|
group = create(:group)
|
|
finder = described_class.new(user, nil, group_id: group.id)
|
|
|
|
expect(finder.execute).to eq(group)
|
|
end
|
|
end
|
|
end
|
|
end
|