gitlab-org--gitlab-foss/spec/services
Douwe Maan 03b12ee550 Merge branch 'fix-commits-manual-merge' into 'master'
Fix bug where manually merged branches in a MR would end up with an empty diff

This bug manifested in 8.1 with the refactoring of `RefreshService`. Here's what happens:

1. User create a new branch `foo`.
2. User creates a merge request for `foo`.
3. User merges `foo` into `master` by hand.
4. `RefreshService` reloads the merge request. Since `master` is equivalent to `foo`, this results in an empty diff.
5. `RefreshService` then closes the MR.

This wasn't an issue when you use the normal "Accept Merge Request" flow because the act of clicking the button closes the merge request, so step 4 never happens.

Closes #3314

See merge request !1758
2015-11-09 11:12:42 +00:00
..
ci Fix tests 2015-11-08 23:55:47 +01:00
issues Fix Style/Blocks cop violations 2015-06-22 16:00:54 -04:00
merge_requests Add spec for manual merge of merge request 2015-11-06 10:48:25 -08:00
milestones Add group service spec. 2014-06-30 15:00:12 +02:00
notes Fix Style/TrailingBlankLines cop violations 2015-06-22 14:38:33 -04:00
projects Fix: Images cannot show when projects' path was changed 2015-10-14 18:50:35 +03:00
archive_repository_service_spec.rb Clear archive cache asynchronously 2015-10-20 16:53:37 +02:00
create_snippet_service_spec.rb Use stub_application_setting in a few more specs 2015-07-06 22:39:56 -04:00
destroy_group_service_spec.rb Change `foo.should` syntax to `expect(foo).to` in specs 2015-06-13 18:37:30 -04:00
event_create_service_spec.rb Create a "destroyed Milestone" event and keep Milestone events around in the DB 2015-09-15 05:51:11 -07:00
git_push_service_spec.rb Add a system note and update relevant merge requests when a branch is deleted or re-added 2015-10-15 23:54:13 -07:00
git_tag_push_service_spec.rb Remove unnecessary whitespace between let and ( 2015-06-22 14:39:07 +02:00
notification_service_spec.rb Note the original location of a moved project when notifying users of the move 2015-10-01 09:54:56 +03:00
search_service_spec.rb Updated rspec to rspec 3.x syntax 2015-02-12 19:17:35 +01:00
system_hooks_service_spec.rb hooks: Add full project namespace to payload 2015-10-02 19:44:33 +02:00
system_note_service_spec.rb Reorder system note verb to say "Restored source branch X" instead of "Source branch X restored" 2015-10-16 00:51:25 -07:00
test_hook_service_spec.rb Remove unnecessary whitespace between let and ( 2015-06-22 14:39:07 +02:00
update_snippet_service_spec.rb Use stub_application_setting in a few more specs 2015-07-06 22:39:56 -04:00