kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/helpers
History
Rémy Coutable 3d72cb897e Merge branch '18019-fix-wiki-linking' into 'master' 
Fix wiki linking behavior for markdown wiki pages

Related to #18019 

- As per the documentation in !4372 

## TODO
- [ ] !4432 Have wiki linking behave as per the documentation
    - [x] Move `WikiLinkFilter` specs to the pipeline level
    - [x] Verify current behavior on wiki `show` page
    - [x] Fix current behavior on wiki `show` page
    - [x] Verify current behaviour on wiki preview
    - [x] Fix current behaviour on wiki preview
        - [x] Rewrite all links and get preview links working
        - [x] Make sure all links are on-par with the wiki `show` page
        - [x] TDD `WikiLinkFilter` and get it working
        - [x] Hook `WikiLinkFilter` up
    - [x] Fix tests 
        - [x] Fix `markdown_spec`
        - [x] Fix `wiki` spinach feature
        - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/4f50dd2/builds) to pass
        - [x] Make sure all wiki-related pages are working as expected (history, all pages, etc.)
    - [x] Test in different ruby versions
    - [x] GitLab instances hosted on a relative URL
    - [x] Non-markdown rendering formats?
        - [x] RDoc
        - [x] ASCIIDoc
        - [x] Create issues to fix things for RDoc and ASCIIDoc
    - [x] Gauge performance impact
    - [x] Refactor
    - [x] Re-organize commits
    - [x] Make sure [build](f860e9a8dc/builds) passes
    - [x] Respond to @rymai's comments
        - [x] `class WikiLinkFilter < HTML::Pipeline::Filter`
        - [x] blank line after guard clause
        - [x] keyword arguments for `wiki` and `slug`
        - [x] invert the condition
        - [x] inline `user` in spec
        - [x] Make sure spec names are not out of date
        - [x] Comment for each rewrite rule
    - [x] Add CHANGELOG entry
    - [x] Reorganize commits
    - [x] Make sure [build](19b91e749a/builds) passes
    - [ ] Wait for merge

See merge request !4432
 		2016-06-09 08:37:27 +00:00
..
appearances_helper.rb Start adding SVG icons 2016-06-08 12:56:02 -05:00
application_helper.rb Merge branch 'issue-filter-name-options' into 'master' 2016-05-25 19:44:06 +00:00
application_settings_helper.rb Allow custom text on 'almost there' page 2016-06-08 19:08:53 +01:00
auth_helper.rb Add a `U2fRegistrations` table/model. 2016-06-06 12:50:31 +05:30
blob_helper.rb Dropdown implementation 2016-05-20 15:58:36 -05:00
branches_helper.rb
…
broadcast_messages_helper.rb
…
button_helper.rb Fix wiki project clone address error 2016-06-02 09:46:26 +02:00
ci_status_helper.rb Rename all ci_commit[s] in application code to pipeline[s] 2016-06-03 16:27:50 +02:00
commits_helper.rb Reduced number of buttons in commit header 2016-05-26 11:19:11 +01:00
compare_helper.rb
…
dashboard_helper.rb
…
diff_helper.rb Enable Style/RedundantParentheses rubocop cop 2016-05-30 15:07:18 +02:00
dropdowns_helper.rb Add multi select stay open functionality 2016-03-25 08:10:25 -04:00
emails_helper.rb Syntax-highlight diffs in push emails 2016-05-17 13:23:17 +01:00
events_helper.rb Remove `event_to_atom` helper 2016-05-23 12:37:40 -04:00
explore_helper.rb Make projects sort dropdown shared so it can be reused for other pages 2016-03-04 19:26:10 +01:00
external_wiki_helper.rb
…
form_helper.rb Standardize the way we check for and display form errors 2016-04-04 21:37:07 -04:00
git_helper.rb
…
gitlab_markdown_helper.rb Hook up the updated `WikiLinkFilter` to the wiki controllers. 2016-06-09 10:15:01 +05:30
gitlab_routing_helper.rb Fix CI tests 2016-05-12 13:03:04 -05:00
graph_helper.rb
…
groups_helper.rb Fix link to blank group icon 2016-06-02 11:19:27 +01:00
icons_helper.rb audit log UI update 2016-03-02 17:06:01 +00:00
import_helper.rb Fix GitHub project's link on import page when provider has a custom URL 2016-04-19 13:21:30 -03:00
issuables_helper.rb Remove prev/next buttons on issues and merge requests 2016-06-06 12:01:50 -04:00
issues_helper.rb Merge branch 'master' into awardables 2016-05-30 18:54:08 +02:00
javascript_helper.rb Fix indentation 2016-06-01 19:42:49 -06:00
labels_helper.rb Updated label links to work correctly for filtering 2016-04-26 09:13:03 +01:00
merge_requests_helper.rb Refactor revert_commit_link helper. 2016-02-19 13:14:54 -05:00
milestones_helper.rb Fix an issue causing the Dashboard/Milestones page to be blank 2016-03-23 12:02:15 +01:00
namespaces_helper.rb hide help block when user is creating a new project inside a group 2016-04-12 14:41:34 +01:00
nav_helper.rb Add fade out to left side of layout nav; remove dropdown nav helper; remove controls button from mobile 2016-05-25 17:14:28 -05:00
notes_helper.rb Extract LegacyDiffNote out of Note 2016-05-13 17:31:43 -05:00
notifications_helper.rb Notifications dropdown on project page now has descriptions 2016-06-07 15:02:00 +01:00
page_layout_helper.rb Implement top navigation concept for profile area 2016-04-19 20:05:30 +02:00
preferences_helper.rb Implementing 'Groups View' and 'TODOs View' as options for dashboard preferences. 2016-03-24 19:59:54 +01:00
projects_helper.rb Allow anonymous user to access pipelines 2016-05-23 01:31:51 +02:00
runners_helper.rb
…
search_helper.rb Codestyle: make sure we have space around operators 2016-05-13 04:46:56 -03:00
selects_helper.rb Codestyle: make sure we have space around operators 2016-05-13 04:46:56 -03:00
snippets_helper.rb Remove `Snippet#expires_at` 2016-03-05 18:12:17 -05:00
sorting_helper.rb Sort by label priority 2016-06-06 11:59:49 -05:00
submodule_helper.rb
…
tab_helper.rb Use start_with? instead of regex 2016-05-24 00:23:23 +02:00
tags_helper.rb
…
time_helper.rb
…
todos_helper.rb Add tooltips to todo target links 2016-05-30 23:05:02 -04:00
tree_helper.rb Add support to cherry-pick any commit 2016-04-18 15:39:07 +08:00
triggers_helper.rb
…
version_check_helper.rb
…
visibility_level_helper.rb Address feedback 2016-03-22 00:09:20 +01:00