fd392cd725
A process that spews a lot of output to stderr or stdout could stall out due to the pipe buffer being full. As described in https://bugs.ruby-lang.org/issues/9082, we can use the trick used in Ruby's capture3 function to read the pipes in separate threads. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6895
88 lines
2.4 KiB
Ruby
88 lines
2.4 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::Popen do
|
|
let(:path) { Rails.root.join('tmp').to_s }
|
|
|
|
before do
|
|
@klass = Class.new(Object)
|
|
@klass.send(:include, described_class)
|
|
end
|
|
|
|
describe '.popen_with_detail' do
|
|
subject { @klass.new.popen_with_detail(cmd) }
|
|
|
|
let(:cmd) { %W[#{Gem.ruby} -e $stdout.puts(1);$stderr.puts(2);exit(3)] }
|
|
|
|
it { expect(subject.cmd).to eq(cmd) }
|
|
it { expect(subject.stdout).to eq("1\n") }
|
|
it { expect(subject.stderr).to eq("2\n") }
|
|
it { expect(subject.status.exitstatus).to eq(3) }
|
|
it { expect(subject.duration).to be_kind_of(Numeric) }
|
|
end
|
|
|
|
context 'zero status' do
|
|
before do
|
|
@output, @status = @klass.new.popen(%w(ls), path)
|
|
end
|
|
|
|
it { expect(@status).to be_zero }
|
|
it { expect(@output).to include('tests') }
|
|
end
|
|
|
|
context 'non-zero status' do
|
|
before do
|
|
@output, @status = @klass.new.popen(%w(cat NOTHING), path)
|
|
end
|
|
|
|
it { expect(@status).to eq(1) }
|
|
it { expect(@output).to include('No such file or directory') }
|
|
end
|
|
|
|
context 'unsafe string command' do
|
|
it 'raises an error when it gets called with a string argument' do
|
|
expect { @klass.new.popen('ls', path) }.to raise_error(RuntimeError)
|
|
end
|
|
end
|
|
|
|
context 'with custom options' do
|
|
let(:vars) { { 'foobar' => 123, 'PWD' => path } }
|
|
let(:options) { { chdir: path } }
|
|
|
|
it 'calls popen3 with the provided environment variables' do
|
|
expect(Open3).to receive(:popen3).with(vars, 'ls', options)
|
|
|
|
@output, @status = @klass.new.popen(%w(ls), path, { 'foobar' => 123 })
|
|
end
|
|
end
|
|
|
|
context 'with a process that writes a lot of data to stderr' do
|
|
let(:test_string) { 'The quick brown fox jumped over the lazy dog' }
|
|
# The pipe buffer is typically 64K. This string is about 440K.
|
|
let(:spew_command) { ['bash', '-c', "for i in {1..10000}; do echo '#{test_string}' 1>&2; done"] }
|
|
|
|
it 'returns zero' do
|
|
output, status = @klass.new.popen(spew_command, path)
|
|
|
|
expect(output).to include(test_string)
|
|
expect(status).to eq(0)
|
|
end
|
|
end
|
|
|
|
context 'without a directory argument' do
|
|
before do
|
|
@output, @status = @klass.new.popen(%w(ls))
|
|
end
|
|
|
|
it { expect(@status).to be_zero }
|
|
it { expect(@output).to include('spec') }
|
|
end
|
|
|
|
context 'use stdin' do
|
|
before do
|
|
@output, @status = @klass.new.popen(%w[cat]) { |stdin| stdin.write 'hello' }
|
|
end
|
|
|
|
it { expect(@status).to be_zero }
|
|
it { expect(@output).to eq('hello') }
|
|
end
|
|
end
|