kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/views
History
Douwe Maan 3a857e0e6c Merge branch '17333-u2f-only-after-authenticator' into 'master' 
Don't allow U2F set up unless an authenticator app is set up

Closes #17333 

# TODO

- [ ]  #17333 Authenticator should be set up before enabling U2F
    - [x]  Implementation
    - [x]  Fix/add tests
    - [x]  Refactor
    - [x]  Wait for [build](964c98a3c4/builds) to pass
    - [x]  Assign to endboss for review
    - [x]  Address @DouweM's comments
        - [x]  No need for `javascript:void(0)`
        - [x]  Add screenshots
    - [ ]  Wait for merge

# Screenshots

![Screen_Shot_2016-06-15_at_8.18.03_AM](/uploads/26531fa7f6e5d7617fd11d1779021b4f/Screen_Shot_2016-06-15_at_8.18.03_AM.png)
![Screen_Shot_2016-06-15_at_8.18.37_AM](/uploads/ceaae97a987a15d3e04dd76aa8a944bd/Screen_Shot_2016-06-15_at_8.18.37_AM.png)
![Screen_Shot_2016-06-15_at_8.18.47_AM](/uploads/394224d5fcff759d5acc3bf39a138530/Screen_Shot_2016-06-15_at_8.18.47_AM.png)

See merge request !4585
2016-06-15 10:12:55 +00:00
..
abuse_report_mailer
abuse_reports
admin Add request access for groups 2016-06-14 13:07:26 +02:00
award_emoji Move award_menu_url variable into gon object. 2016-06-09 03:37:40 +03:00
ci
dashboard Don't try to count a relation with aliases 2016-06-10 14:29:08 +01:00
devise Merge branch 'rs-fix-ldap-2fa-login' into 'master' 2016-06-09 18:43:22 +00:00
doorkeeper
email_rejection_mailer
emojis
errors
events Fixed issue with activity links not being consistent 2016-06-02 09:11:44 +01:00
explore
groups UI and copywriting improvements 2016-06-14 13:18:14 +02:00
help Update the browser gem. 2016-06-06 12:50:31 +05:30
import Add a message warning user that Webhooks will be disabled 2016-06-06 12:07:45 -03:00
invites
issues Add more information into RSS fead for issues 2016-06-13 09:41:34 -07:00
kaminari/gitlab Upgrade Kaminari from 0.16.3 to 0.17.0. 2016-05-31 14:14:16 -06:00
layouts Merge branch 'manual-todos-issuable-sidebar' into 'master' 2016-06-14 22:01:43 +00:00
notify UI and copywriting improvements 2016-06-14 13:18:14 +02:00
profiles Don't allow clicking on "Setup New U2F Device" unless an authenticator app has been set up. 2016-06-15 08:16:11 +05:30
projects Merge branch 'master' into 13948-access-request-to-projects-and-groups 2016-06-14 16:23:16 +02:00
repository_check_mailer
search
shared Merge branch 'manual-todos-issuable-sidebar' into 'master' 2016-06-14 22:01:43 +00:00
sherlock Use better_errors editor links in sherlock 2016-06-06 18:27:26 -04:00
snippets
u2f Don't allow clicking on "Setup New U2F Device" unless an authenticator app has been set up. 2016-06-15 08:16:11 +05:30
users Add tests for dates on tooltips 2016-06-09 14:38:24 -05:00