2c46c4523f
Store both the project and identifier of extracted references. This prevents `ReferenceExtractor` from returning objects in the wrong project for cross-project references.
105 lines
3.5 KiB
Ruby
105 lines
3.5 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Gitlab::ReferenceExtractor do
|
|
it 'extracts username references' do
|
|
subject.analyze('this contains a @user reference', nil)
|
|
subject.users.should == [{ project: nil, id: 'user' }]
|
|
end
|
|
|
|
it 'extracts issue references' do
|
|
subject.analyze('this one talks about issue #1234', nil)
|
|
subject.issues.should == [{ project: nil, id: '1234' }]
|
|
end
|
|
|
|
it 'extracts JIRA issue references' do
|
|
Gitlab.config.gitlab.stub(:issues_tracker).and_return('jira')
|
|
subject.analyze('this one talks about issue JIRA-1234', nil)
|
|
subject.issues.should == [{ project: nil, id: 'JIRA-1234' }]
|
|
end
|
|
|
|
it 'extracts merge request references' do
|
|
subject.analyze("and here's !43, a merge request", nil)
|
|
subject.merge_requests.should == [{ project: nil, id: '43' }]
|
|
end
|
|
|
|
it 'extracts snippet ids' do
|
|
subject.analyze('snippets like $12 get extracted as well', nil)
|
|
subject.snippets.should == [{ project: nil, id: '12' }]
|
|
end
|
|
|
|
it 'extracts commit shas' do
|
|
subject.analyze('commit shas 98cf0ae3 are pulled out as Strings', nil)
|
|
subject.commits.should == [{ project: nil, id: '98cf0ae3' }]
|
|
end
|
|
|
|
it 'extracts multiple references and preserves their order' do
|
|
subject.analyze('@me and @you both care about this', nil)
|
|
subject.users.should == [
|
|
{ project: nil, id: 'me' },
|
|
{ project: nil, id: 'you' }
|
|
]
|
|
end
|
|
|
|
it 'leaves the original note unmodified' do
|
|
text = 'issue #123 is just the worst, @user'
|
|
subject.analyze(text, nil)
|
|
text.should == 'issue #123 is just the worst, @user'
|
|
end
|
|
|
|
it 'handles all possible kinds of references' do
|
|
accessors = Gitlab::Markdown::TYPES.map { |t| "#{t}s".to_sym }
|
|
subject.should respond_to(*accessors)
|
|
end
|
|
|
|
context 'with a project' do
|
|
let(:project) { create(:project) }
|
|
|
|
it 'accesses valid user objects on the project team' do
|
|
@u_foo = create(:user, username: 'foo')
|
|
@u_bar = create(:user, username: 'bar')
|
|
create(:user, username: 'offteam')
|
|
|
|
project.team << [@u_foo, :reporter]
|
|
project.team << [@u_bar, :guest]
|
|
|
|
subject.analyze('@foo, @baduser, @bar, and @offteam', project)
|
|
subject.users_for(project).should == [@u_foo, @u_bar]
|
|
end
|
|
|
|
it 'accesses valid issue objects' do
|
|
@i0 = create(:issue, project: project)
|
|
@i1 = create(:issue, project: project)
|
|
|
|
subject.analyze("##{@i0.iid}, ##{@i1.iid}, and #999.", project)
|
|
subject.issues_for(project).should == [@i0, @i1]
|
|
end
|
|
|
|
it 'accesses valid merge requests' do
|
|
@m0 = create(:merge_request, source_project: project, target_project: project, source_branch: 'aaa')
|
|
@m1 = create(:merge_request, source_project: project, target_project: project, source_branch: 'bbb')
|
|
|
|
subject.analyze("!999, !#{@m1.iid}, and !#{@m0.iid}.", project)
|
|
subject.merge_requests_for(project).should == [@m1, @m0]
|
|
end
|
|
|
|
it 'accesses valid snippets' do
|
|
@s0 = create(:project_snippet, project: project)
|
|
@s1 = create(:project_snippet, project: project)
|
|
@s2 = create(:project_snippet)
|
|
|
|
subject.analyze("$#{@s0.id}, $999, $#{@s2.id}, $#{@s1.id}", project)
|
|
subject.snippets_for(project).should == [@s0, @s1]
|
|
end
|
|
|
|
it 'accesses valid commits' do
|
|
commit = project.repository.commit('master')
|
|
|
|
subject.analyze("this references commits #{commit.sha[0..6]} and 012345",
|
|
project)
|
|
extracted = subject.commits_for(project)
|
|
extracted.should have(1).item
|
|
extracted[0].sha.should == commit.sha
|
|
extracted[0].message.should == commit.message
|
|
end
|
|
end
|
|
end
|