gitlab-org--gitlab-foss/lib/gitlab
Jacob Vosmaer 35b9274f12 Stop calling UnlinkRepositoryFromObjectPool RPC
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/59777.

In earlier iterations of our implementation of Git object deduplication
we thought we would be making extensive use of Git remotes in pool
repositories in the future, and that we should manage these remotes
carefully from the start. We now expect we only care about one remote,
namely the source project. The other remotes are there only for forensic
purposes.

Before this MR we tried to also remove pool remotes when member projects
got deleted, with the UnlinkRepositoryFromObjectPool RPC. This is
fragile when there are race conditions (see
https://gitlab.com/gitlab-org/gitaly/issues/1568#note_153955926). We
have spent some time making this RPC less fragile in
https://gitlab.com/gitlab-org/gitaly/merge_requests/1151 but looking at
this problem again, I think we should just stop calling it.
2019-04-02 13:20:26 +00:00
..
access Refactor code for protecting default branches 2019-01-16 14:25:14 +01:00
auth Backport 'Update user name upon LDAP sync' from EE 2019-03-25 11:16:01 +01:00
background_migration Remove additional logging 2019-04-01 15:05:52 -03:00
badge Add :preparing status to HasStatus 2019-03-20 11:48:31 +11:00
bare_repository_import Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
bitbucket_import Run rubocop -a 2019-03-13 13:42:43 +00:00
bitbucket_server_import Run rubocop -a 2019-03-13 13:42:43 +00:00
cache Use strong memoize utility 2018-11-26 17:41:41 +08:00
chat Move ChatOps to Core 2019-02-20 21:29:48 +00:00
checks Allow users to create protected branches via CLI 2019-03-21 19:53:04 +08:00
ci Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into jarv/dev-to-gitlab-2019-04-02 2019-04-02 10:12:32 +02:00
cleanup Use directories.new when getting S3 directory 2018-12-27 11:06:06 +01:00
cluster
config Make CI refs matching to to use UntrustedRegexp 2019-03-15 14:38:28 +01:00
conflict
cross_project_access
cycle_analytics Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
danger Apply suggestion to lib/gitlab/danger/helper.rb 2019-03-25 21:16:43 +00:00
data_builder Fix private user email being visible in tag webhooks 2019-01-31 16:51:18 +01:00
database Run rubocop -a 2019-03-13 13:42:43 +00:00
dependency_linker Raise not implemented error on BaseLinker for package_url 2019-02-25 10:22:13 -03:00
diff Memoize old_blob and new_blob to improve performance 2019-03-28 12:11:37 +00:00
discussions_diff Cache diff highlight in discussions 2018-12-21 16:59:21 -02:00
downtime_check
email Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
error_tracking Update Sentry client to get project list 2019-01-31 10:05:29 +00:00
etag_caching Improve the GitHub and Gitea import feature table interface 2019-02-13 00:15:57 +00:00
fogbugz_import Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
gfm Enable CommonMark source line position information 2019-01-21 13:45:16 -06:00
git Stop calling UnlinkRepositoryFromObjectPool RPC 2019-04-02 13:20:26 +00:00
git_access_result
gitaly_client Stop calling UnlinkRepositoryFromObjectPool RPC 2019-04-02 13:20:26 +00:00
github_import GitHub importer: Use the project creator to create branches from forks 2019-03-23 07:29:35 -07:00
gitlab_import Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
gl_repository Allow multiple repositories per project 2019-03-26 13:21:03 +01:00
google_code_import Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
gpg Avoid race conditions when creating GpgSignature 2019-02-06 15:24:46 +01:00
grape_logging Log Gitaly RPC duration to api_json.log and production_json.log 2019-03-27 06:01:21 -05:00
graphql Monitor GraphQL with Prometheus 2019-04-02 10:26:53 +00:00
graphs Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
hashed_storage Fix storage migration check for non-empty queues 2019-03-17 00:27:38 +01:00
health_checks Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
hook_data Fix whitespace in IssueBuilder/MergeRequestBuilder 2019-03-15 17:25:40 +01:00
i18n Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
import Force to recreate all diffs on import 2019-03-26 12:25:25 +00:00
import_export Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into jarv/dev-to-gitlab-2019-04-02 2019-04-02 10:12:32 +02:00
kubernetes Merge branch '56937-edit-knative-domain' into 'master' 2019-03-07 12:43:34 +00:00
legacy_github_import Run rubocop -a 2019-03-13 13:42:43 +00:00
manifest_import Enable even more frozen string for lib/gitlab 2018-11-16 17:41:14 -08:00
metrics Run rubocop -a 2019-03-13 13:42:43 +00:00
middleware Fix health checks not working behind load balancers 2019-03-12 12:46:40 -07:00
patch Use correct integrity hash for sprockets caching 2019-02-08 13:14:39 +01:00
performance_bar Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
popen Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
profiler Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
project_authorizations Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
prometheus Correct ordering of metrics 2018-12-21 16:41:58 +05:30
query_limiting Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
quick_actions Extend quick actions dsl 2019-03-29 12:53:28 +02:00
redis Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
request_profiler Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
sanitizers Rake task for removing exif from uploads 2019-04-02 07:48:35 +00:00
search Optimized file search to work without limits 2018-12-06 09:25:09 +01:00
serializer Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
sherlock Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
sidekiq_logging Limit Sidekiq args logging to 10 KB of JSON 2019-01-22 10:54:12 +00:00
sidekiq_middleware Fix the last-ditch memory killer pgroup SIGKILL 2019-03-09 13:34:06 +00:00
sidekiq_status Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
sidekiq_versioning Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
slash_commands Move ChatOps to Core 2019-02-20 21:29:48 +00:00
sql Allow filtering labels by a single character 2019-03-13 10:54:43 +00:00
template Add Dependency Scanning vendored template for EE 2019-03-07 09:31:37 +00:00
testing Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
tracing Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
untrusted_regexp Make CI refs matching to to use UntrustedRegexp 2019-03-15 14:38:28 +01:00
utils Add cache to the 'compile-assets' and 'gitlab:assets:compile' jobs 2019-02-05 14:04:54 +01:00
verify Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
view/presenter Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
webpack Enable even more frozen string for lib/gitlab 2018-11-19 18:24:22 -08:00
access.rb Add highest_role method to User 2019-03-22 09:54:03 +00:00
action_rate_limiter.rb
allowable.rb
app_logger.rb
asciidoc.rb
audit_json_logger.rb
auth.rb Fix #44332 - Add support for profile and email 2019-02-06 16:48:36 +00:00
authorized_keys.rb Handle cases when authorized_keys doesn't exist 2019-03-20 09:16:26 +08:00
background_migration.rb Address review comments 2019-02-19 14:00:53 -03:00
base_doorkeeper_controller.rb
blame.rb
blob_helper.rb Fixing image lfs bug and also displaying text lfs 2018-12-27 16:51:07 +01:00
branch_push_merge_commit_analyzer.rb Fix commit with two parents is set with wrong direct_ancestor 2018-12-07 21:00:47 +08:00
build_access.rb
changes_list.rb
chat.rb Move ChatOps to Core 2019-02-20 21:29:48 +00:00
chat_name_token.rb
ci_access.rb
closing_issue_extractor.rb
color_schemes.rb Add "none" syntax highlighting "color" scheme 2018-12-18 00:34:50 +00:00
config_helper.rb
content_disposition.rb Add Rails 6 deprecation error message 2019-02-05 04:47:40 -08:00
contributions_calendar.rb Eliminate most N+1 queries loading UserController#calendar_activities 2019-03-01 10:57:09 -08:00
contributor.rb
correlation_id.rb Revert "Prefer to use correlation-id in logs" 2018-12-06 21:46:31 +01:00
cross_project_access.rb
crypto_helper.rb Ensure that db encryption keys have proper bytesize 2018-11-22 15:35:49 +01:00
current_settings.rb Use a Gitlab::FakeApplicationSettings when migrations are pending 2019-03-26 23:02:57 +01:00
daemon.rb
database.rb Add helper method to return a human-friendly name for database adapter 2019-03-21 19:03:26 -03:00
dependency_linker.rb
downtime_check.rb
ee_compat_check.rb Don't ignore conflicts in db/schema.rb 2019-01-04 16:22:00 +01:00
emoji.rb
encoding_helper.rb Allow streaming io objects into Gitaly 2019-04-01 20:17:40 +02:00
environment.rb
environment_logger.rb
exclusive_lease.rb
exclusive_lease_helpers.rb Lock writes to trace stream 2018-11-27 17:55:20 +01:00
fake_application_settings.rb Introduce ApplicationSettingImplementation yay 2019-03-19 13:01:37 +08:00
favicon.rb Refactor Gitlab::Favicon for EE 2019-03-12 11:10:40 +01:00
file_detector.rb Revert "Merge branch..." 2019-03-19 09:36:05 +00:00
file_finder.rb Optimized file search to work without limits 2018-12-06 09:25:09 +01:00
file_markdown_link_builder.rb
file_type_detection.rb
git.rb Revert "Use to_s.start_with? in tag/branch ref method" 2018-12-08 19:28:56 +01:00
git_access.rb Move push size check to EE module 2019-01-02 15:31:33 +01:00
git_access_wiki.rb Don't run single change checks when changes are unknown 2019-01-02 15:31:32 +01:00
git_logger.rb
git_post_receive.rb Add support for Git push options, specifically ci.skip 2018-12-31 13:57:53 -05:00
git_ref_validator.rb Gracefully handle references with null bytes 2018-11-26 14:14:16 -08:00
gitaly_client.rb Merge branch 'jc-remove-find-all-tags-ff' into 'master' 2019-04-01 18:00:23 +00:00
github_import.rb
gl_id.rb
gl_repository.rb Allow multiple repositories per project 2019-03-26 13:21:03 +01:00
gon_helper.rb Creates a function to check if repo is EE 2019-03-04 08:20:37 +00:00
gpg.rb Remove rails4 specific code 2018-12-16 10:48:41 +01:00
graphql.rb Enable GraphQL API endpoint 2018-12-13 10:12:13 +00:00
group_search_results.rb restrict user result set by the scoped group 2019-03-14 18:21:02 +01:00
highlight.rb Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
http.rb
http_io.rb Fix deadlock on ChunkedIO 2018-11-26 13:15:46 +01:00
i18n.rb
identifier.rb
import_export.rb
import_formatter.rb
import_sources.rb Fix ConstantName rubocop offense 2018-12-09 22:45:48 +05:00
incoming_email.rb Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
insecure_key_fingerprint.rb
issuable_metadata.rb
issuable_sorter.rb
issuables_count_for_state.rb
issues_labels.rb
job_waiter.rb
json_cache.rb Gracefully handles excluded fields from attributes during serialization 2019-03-20 13:21:29 -03:00
json_logger.rb Log and pass correlation-id between Unicorn, Sidekiq and Gitaly 2018-12-06 20:46:14 +01:00
kubernetes.rb Update dashboards to additionally use new environment selector 2019-03-21 08:06:47 +00:00
language_data.rb
language_detection.rb
lazy.rb
lfs_token.rb Include expires_in for LFS authentication payload 2019-02-15 09:29:52 +11:00
logger.rb
loop_helpers.rb Remove expired artifacts periodically 2019-01-24 20:50:42 +09:00
mail_room.rb
markup_helper.rb
metrics.rb
multi_collection_paginator.rb
namespace_sanitizer.rb
null_request_store.rb
object_hierarchy.rb Rename GroupHierarchy into ObjectHierarchy 2018-12-19 15:24:29 +01:00
omniauth_initializer.rb
optimistic_locking.rb
other_markup.rb
otp_key_rotator.rb
pages.rb
pages_client.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
pages_transfer.rb
path_regex.rb Fix slow project reference pattern regex 2019-01-31 16:51:16 +01:00
performance_bar.rb
plugin.rb
plugin_logger.rb
polling_interval.rb
popen.rb
private_commit_email.rb Match users better by their private commit email 2018-11-19 12:45:07 +00:00
profiler.rb Allow profiler to authenticate by stubbing users directly 2018-11-26 11:18:03 +00:00
project_search_results.rb project's user search includes group members too 2019-03-14 18:21:02 +01:00
project_service_logger.rb
project_template.rb Add Android template 2019-03-07 20:02:40 +01:00
project_transfer.rb
prometheus_client.rb
protocol_access.rb
proxy_http_connection_adapter.rb
query_limiting.rb
recaptcha.rb Apply recaptcha API changes in 4.0 2019-03-08 15:04:04 +01:00
reference_counter.rb
reference_extractor.rb
regex.rb
repo_path.rb Allow multiple repositories per project 2019-03-26 13:21:03 +01:00
repository_cache.rb Revert "Merge branch '3062-improve-project-cache' into 'master'" 2019-01-08 13:14:06 -08:00
repository_cache_adapter.rb
repository_check_logger.rb
request_context.rb Fix health checks not working behind load balancers 2019-03-12 12:46:40 -07:00
request_forgery_protection.rb
request_profiler.rb
route_map.rb
routing.rb
safe_request_store.rb Change SafeRequestStore#write to accept an options hash 2018-12-17 19:57:03 -02:00
search_results.rb move users method to public section 2019-03-14 18:30:30 +01:00
seeder.rb Backport of elastic-test-repos from EE 2019-01-08 17:18:15 -06:00
sentry.rb Extract process_name from GitLab::Sentry 2019-01-16 15:29:05 +02:00
setup_helper.rb
shard_health_cache.rb
shell.rb Integrate Gitlab::Keys with Gitlab::Shell 2019-03-19 11:16:21 +00:00
shell_adapter.rb
sherlock.rb
sidekiq_config.rb Backport support for finding EE workers 2019-03-12 17:41:38 +01:00
sidekiq_logger.rb
sidekiq_signals.rb Fix Sidekiq process group killing 2019-03-07 12:37:59 +00:00
sidekiq_status.rb
sidekiq_versioning.rb
snippet_search_results.rb
ssh_public_key.rb Fix ConstantName rubocop offense 2018-12-09 22:45:48 +05:00
string_placeholder_replacer.rb
string_range_marker.rb
string_regex_marker.rb
task_helpers.rb Add cache to the 'compile-assets' and 'gitlab:assets:compile' jobs 2019-02-05 14:04:54 +01:00
tcp_checker.rb
template_helper.rb
temporarily_allow.rb
themes.rb
time_tracking_formatter.rb
timeless.rb
tracing.rb Switch back to using regexps in tracing_url_template 2019-02-22 14:47:37 +02:00
tree_summary.rb Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
untrusted_regexp.rb Make CI refs matching to to use UntrustedRegexp 2019-03-15 14:38:28 +01:00
update_path_error.rb
uploads_transfer.rb
url_blocker.rb Add table and model for error tracking settings 2019-01-07 17:55:21 +00:00
url_builder.rb
url_sanitizer.rb Only allow strings in URL::Sanitizer.valid? 2018-12-09 07:59:54 -08:00
usage_data.rb Add error tracking usage counts 2019-03-25 07:42:08 +00:00
user_access.rb Allow protected branch creation via web and API 2019-03-06 12:20:27 +00:00
user_extractor.rb Backport EE changes to UserExtractor to CE 2019-03-18 14:40:09 +01:00
utils.rb Backport try_megabytes_to_bytes from EE 2019-03-12 14:04:05 +01:00
version_info.rb Revert the "What's new" feature 2019-01-29 20:45:47 +00:00
visibility_level.rb
web_ide_commits_counter.rb
wiki_file_finder.rb Remove BATCH_SIZE from WikiFileFinder 2019-02-06 13:22:35 +01:00
workhorse.rb Allow multiple repositories per project 2019-03-26 13:21:03 +01:00