gitlab-org--gitlab-foss/spec/features
Douwe Maan d1c94f034b Merge branch 'explicit-requesters-scope' into 'master'
Exclude requesters from Project#members, Group#members and User#members

## What does this MR do?

It excludes requesters from the `Project#members`, `Group#members` and `User#members` associations, and adds new `Project#requesters` and `Group#requesters` associations.

## Are there points in the code the reviewer needs to double check?

No.

## Why was this MR needed?

Without this, if you call `project.members`, requesters are included in the results! This is at best misleading, and at worst can lead to security issues. By excluding requesters from the `#members` associations, we avoid introducing security inadvertently since you have to call the `#requesters` association explicitly to get requesters.

## What are the relevant issue numbers?

This is something I realized while fixing the security issue #19102.

## Does this MR meet the acceptance criteria?

- [x] I don't think this needs a CHANGELOG since this is an internal change
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4946
2016-07-01 22:23:26 +00:00
..
admin Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
atom Wrap images in divs with Banzai and limit max-height. 2016-06-27 09:16:07 -06:00
dashboard Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
groups/members Merge branch 'explicit-requesters-scope' into 'master' 2016-07-01 22:23:26 +00:00
issues Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
merge_requests Rename ci_commit -> pipeline 2016-06-10 14:41:38 +02:00
profiles Implement @DouweM's feedback. 2016-06-16 08:24:13 +05:30
projects Merge branch 'explicit-requesters-scope' into 'master' 2016-07-01 22:23:26 +00:00
security Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
tags Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
todos Ensure Todos counters doesn't count Todos for projects pending delete 2016-06-17 16:17:43 -03:00
builds_spec.rb Fix specs 2016-06-14 11:38:34 +02:00
ci_lint_spec.rb
commits_spec.rb
container_registry_spec.rb Show proper image ID on registry page 2016-06-21 13:08:10 +02:00
dashboard_issues_spec.rb
dashboard_milestones_spec.rb
environments_spec.rb Tests update 2016-06-21 11:52:51 +01:00
gitlab_flavored_markdown_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
groups_spec.rb
help_pages_spec.rb
issues_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
login_spec.rb
markdown_spec.rb Merge branch '18019-fix-wiki-linking' into 'master' 2016-06-09 08:37:27 +00:00
milestone_spec.rb
notes_on_merge_requests_spec.rb
participants_autocomplete_spec.rb
password_reset_spec.rb
pipelines_spec.rb
profile_spec.rb
projects_spec.rb Fix and remove duplicate specs 2016-06-20 12:36:59 +02:00
runners_spec.rb
search_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
signup_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
task_lists_spec.rb
triggers_spec.rb
u2f_spec.rb Update u2f_spec to cover U2F being disabled until authenticator is set up. 2016-06-15 08:16:54 +05:30
users_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
variables_spec.rb