3e4b45fc21
Previously, this would include the entire User record in the update hash, which was rendered in the response using `to_json`, erroneously exposing every attribute of that record, including their (now removed) private token. Now we only include the user ID, and perform the lookup on-demand.
97 lines
3.3 KiB
Ruby
97 lines
3.3 KiB
Ruby
require 'rails_helper'
|
||
|
||
feature 'Milestone' do
|
||
let(:group) { create(:group, :public) }
|
||
let(:project) { create(:project, :public, namespace: group) }
|
||
let(:user) { create(:user) }
|
||
|
||
before do
|
||
create(:group_member, group: group, user: user)
|
||
project.team << [user, :master]
|
||
sign_in(user)
|
||
end
|
||
|
||
feature 'Create a milestone' do
|
||
scenario 'shows an informative message for a new milestone' do
|
||
visit new_project_milestone_path(project)
|
||
|
||
page.within '.milestone-form' do
|
||
fill_in "milestone_title", with: '8.7'
|
||
fill_in "milestone_start_date", with: '2016-11-16'
|
||
fill_in "milestone_due_date", with: '2016-12-16'
|
||
end
|
||
|
||
find('input[name="commit"]').click
|
||
|
||
expect(find('.alert-success')).to have_content('Assign some issues to this milestone.')
|
||
expect(page).to have_content('Nov 16, 2016–Dec 16, 2016')
|
||
end
|
||
end
|
||
|
||
feature 'Open a milestone with closed issues' do
|
||
scenario 'shows an informative message' do
|
||
milestone = create(:milestone, project: project, title: 8.7)
|
||
|
||
create(:issue, title: "Bugfix1", project: project, milestone: milestone, state: "closed")
|
||
visit project_milestone_path(project, milestone)
|
||
|
||
expect(find('.alert-success')).to have_content('All issues for this milestone are closed. You may close this milestone now.')
|
||
end
|
||
end
|
||
|
||
feature 'Open a project milestone with an existing title' do
|
||
scenario 'displays validation message when there is a project milestone with same title' do
|
||
milestone = create(:milestone, project: project, title: 8.7)
|
||
|
||
visit new_project_milestone_path(project)
|
||
page.within '.milestone-form' do
|
||
fill_in "milestone_title", with: milestone.title
|
||
end
|
||
find('input[name="commit"]').click
|
||
|
||
expect(find('.alert-danger')).to have_content('already being used for another group or project milestone.')
|
||
end
|
||
|
||
scenario 'displays validation message when there is a group milestone with same title' do
|
||
milestone = create(:milestone, project_id: nil, group: project.group, title: 8.7)
|
||
|
||
visit new_group_milestone_path(project.group)
|
||
|
||
page.within '.milestone-form' do
|
||
fill_in "milestone_title", with: milestone.title
|
||
end
|
||
find('input[name="commit"]').click
|
||
|
||
expect(find('.alert-danger')).to have_content('already being used for another group or project milestone.')
|
||
end
|
||
end
|
||
|
||
feature 'Open a milestone' do
|
||
scenario 'shows total issue time spent correctly when no time has been logged' do
|
||
milestone = create(:milestone, project: project, title: 8.7)
|
||
|
||
visit project_milestone_path(project, milestone)
|
||
|
||
page.within('.block.time_spent') do
|
||
expect(page).to have_content 'No time spent'
|
||
expect(page).to have_content 'None'
|
||
end
|
||
end
|
||
|
||
scenario 'shows total issue time spent' do
|
||
milestone = create(:milestone, project: project, title: 8.7)
|
||
issue1 = create(:issue, project: project, milestone: milestone)
|
||
issue2 = create(:issue, project: project, milestone: milestone)
|
||
issue1.spend_time(duration: 3600, user_id: user.id)
|
||
issue1.save!
|
||
issue2.spend_time(duration: 7200, user_id: user.id)
|
||
issue2.save!
|
||
|
||
visit project_milestone_path(project, milestone)
|
||
|
||
page.within('.block.time_spent') do
|
||
expect(page).to have_content '3h'
|
||
end
|
||
end
|
||
end
|
||
end
|