631801674f
Previously we'd use "event.author_email" which translates to "event.author.email". This would result in an extra query being executed _for every event_ just to get the same author's Email address. Instead of doing all this useless work we can just pass the User object returned by "event.author" since: 1. This allows us to re-use the user object's Email address. 2. Authors are eager-loaded, so this doesn't cause any N+1 queries.
26 lines
928 B
Ruby
26 lines
928 B
Ruby
return unless event.visible_to_user?(current_user)
|
|
|
|
xml.entry do
|
|
xml.id "tag:#{request.host},#{event.created_at.strftime("%Y-%m-%d")}:#{event.id}"
|
|
xml.link href: event_feed_url(event)
|
|
xml.title truncate(event_feed_title(event), length: 80)
|
|
xml.updated event.updated_at.xmlschema
|
|
|
|
# We're deliberately re-using "event.author" here since this data is
|
|
# eager-loaded. This allows us to re-use the user object's Email address,
|
|
# instead of having to run additional queries to figure out what Email to use
|
|
# for the avatar.
|
|
xml.media :thumbnail, width: "40", height: "40", url: image_url(avatar_icon(event.author))
|
|
|
|
xml.author do
|
|
xml.username event.author_username
|
|
xml.name event.author_name
|
|
xml.email event.author_public_email
|
|
end
|
|
|
|
xml.summary(type: "xhtml") do |summary|
|
|
event_summary = event_feed_summary(event)
|
|
|
|
summary << event_summary unless event_summary.nil?
|
|
end
|
|
end
|