kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/app/controllers/concerns
History
Stan Hu 41b51c0656 Encode Content-Disposition filenames 
Users downloading non-ASCII attachments would see garbled characters.
When used with object storage, AWS S3 would return an InvalidArgument
error: Header value cannot be represented using ISO-8859-1.

Per RFC 5987 and RFC 6266, Content-Disposition should be encoded
properly. This commit takes the Rails 6 implementation of
ActiveSuppport::Http::ContentDisposition
(https://github.com/rails/rails/pull/33829) and ports it here.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47673
2019-02-04 23:12:44 -08:00
..
accepts_pending_invitations.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
authenticates_with_two_factor.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
boards_responses.rb Backport of 54385-board-policy 2019-01-18 12:43:46 -06:00
checks_collaboration.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
continue_params.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
controller_with_cross_project_access_check.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
creates_commit.rb Revert "Merge branch 'blackst0ne-update-push-new-merge-request-url' into 'master'" 2018-11-07 13:32:20 +00:00
cycle_analytics_params.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
diff_for_path.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
enforces_two_factor_authentication.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
group_tree.rb Rename GroupHierarchy into ObjectHierarchy 2018-12-19 15:24:29 +01:00
hooks_execution.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
internal_redirect.rb Merge branch 'frozen-string-app-controller' into 'master' 2018-09-20 22:53:27 +00:00
issuable_actions.rb Specs for caching and issue controller changes 2019-01-30 23:18:17 +01:00
issuable_collections.rb Save sorting preference for Issues/MRs in BE 2019-01-28 12:48:05 -06:00
issuable_collections_action.rb Save sorting preference for Issues/MRs in BE 2019-01-28 12:48:05 -06:00
issues_calendar.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
labels_as_hash.rb Create labels_as_hash_ concern, modify params for method 2018-10-03 09:13:42 -07:00
lfs_request.rb Make LfsRequest EE-compatible 2018-12-19 16:04:00 +01:00
members_presentation.rb Add MembersPreloader to fix ActiveRecord cop 2018-11-02 21:38:58 +00:00
membership_actions.rb Add subresources removal to member destroy service 2019-01-31 16:52:50 +01:00
milestone_actions.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
notes_actions.rb Merge branch 'security-guest-comments' into 'master' 2018-11-28 19:11:56 -05:00
oauth_applications.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
params_backward_compatibility.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
preview_markdown.rb Allow suggesting single line changes in diffs 2018-12-13 19:17:19 +00:00
project_unauthorized.rb Restore 403 functionality for external auth (EE) 2018-11-01 19:37:32 +13:00
renders_blob.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
renders_commits.rb Check for valid refs in CommitController before doing anything 2018-12-09 21:56:31 -08:00
renders_member_access.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
renders_notes.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
repository_settings_redirect.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
requires_whitelisted_monitoring_client.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
routable_actions.rb Restore 403 functionality for external auth (EE) 2018-11-01 19:37:32 +13:00
send_file_upload.rb Encode Content-Disposition filenames 2019-02-04 23:12:44 -08:00
sends_blob.rb Fixed bug with the content disposition with wiki attachments 2018-10-17 15:47:05 +00:00
service_params.rb Use the EE version of ServiceParams 2018-12-17 17:59:06 +01:00
sessionless_authentication.rb Merge branch 'security-fix-pat-web-access' into 'master' 2018-11-28 19:13:59 -05:00
snippets_actions.rb Add feature flag for workhorse content type calculation 2018-12-06 21:22:39 +00:00
spammable_actions.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
todos_actions.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
toggle_award_emoji.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
toggle_subscription_action.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00
uploads_actions.rb Turned cache_privately? into cache_publicly? 2019-01-22 12:34:11 +01:00
with_performance_bar.rb Simplify by using Gitlab::SafeRequestStore 2018-09-24 12:11:26 -07:00
workhorse_request.rb Enable frozen string in app/controllers/**/*.rb 2018-09-18 21:22:45 -07:00