d13669716a
In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo secondary node). But in GitLab CE it also might be useful to have the "read-only" idea around. So port it back to GitLab CE. Also having the principle of read-only in GitLab CE would hopefully lead to less errors introduced, doing write operations when there aren't allowed for read-only calls. Closes gitlab-org/gitlab-ce#37534.
58 lines
1.6 KiB
Ruby
58 lines
1.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Banzai::Renderer do
|
|
def fake_object(fresh:)
|
|
object = double('object')
|
|
|
|
allow(object).to receive(:respond_to?).with(:cached_markdown_fields).and_return(true)
|
|
allow(object).to receive(:cached_html_up_to_date?).with(:field).and_return(fresh)
|
|
allow(object).to receive(:cached_html_for).with(:field).and_return('field_html')
|
|
|
|
object
|
|
end
|
|
|
|
describe '#render_field' do
|
|
let(:renderer) { described_class }
|
|
|
|
context 'without cache' do
|
|
let(:commit) { create(:project, :repository).commit }
|
|
|
|
it 'returns cacheless render field' do
|
|
expect(renderer).to receive(:cacheless_render_field).with(commit, :title)
|
|
|
|
renderer.render_field(commit, :title)
|
|
end
|
|
end
|
|
|
|
context 'with cache' do
|
|
subject { renderer.render_field(object, :field) }
|
|
|
|
context 'with a stale cache' do
|
|
let(:object) { fake_object(fresh: false) }
|
|
|
|
it 'caches and returns the result' do
|
|
expect(object).to receive(:refresh_markdown_cache!)
|
|
|
|
is_expected.to eq('field_html')
|
|
end
|
|
|
|
it "skips database caching on a GitLab read-only instance" do
|
|
allow(Gitlab::Database).to receive(:read_only?).and_return(true)
|
|
expect(object).to receive(:refresh_markdown_cache!)
|
|
|
|
is_expected.to eq('field_html')
|
|
end
|
|
end
|
|
|
|
context 'with an up-to-date cache' do
|
|
let(:object) { fake_object(fresh: true) }
|
|
|
|
it 'uses the cache' do
|
|
expect(object).to receive(:refresh_markdown_cache!).never
|
|
|
|
is_expected.to eq('field_html')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|