d3a3db4218
This commit changes how we eager-load projects, routes, and namespaces required by the deploy keys endpoint, getting a 10x improvement in my local testing. The endpoint still doesn't scale in-general, but going from ~13 seconds to dump a 63K result to generating the same thing in ~1.6 seconds seems like a good improvement to me.
53 lines
1.3 KiB
Ruby
53 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class DeployKey < Key
|
|
include IgnorableColumn
|
|
include FromUnion
|
|
|
|
has_many :deploy_keys_projects, inverse_of: :deploy_key, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
|
|
has_many :projects, through: :deploy_keys_projects
|
|
|
|
scope :in_projects, ->(projects) { joins(:deploy_keys_projects).where('deploy_keys_projects.project_id in (?)', projects) }
|
|
scope :are_public, -> { where(public: true) }
|
|
scope :with_projects, -> { includes(deploy_keys_projects: { project: [:route, :namespace] }) }
|
|
|
|
ignore_column :can_push
|
|
|
|
accepts_nested_attributes_for :deploy_keys_projects
|
|
|
|
def private?
|
|
!public?
|
|
end
|
|
|
|
def orphaned?
|
|
self.deploy_keys_projects.empty?
|
|
end
|
|
|
|
def almost_orphaned?
|
|
self.deploy_keys_projects.count == 1
|
|
end
|
|
|
|
def destroyed_when_orphaned?
|
|
self.private?
|
|
end
|
|
|
|
def user
|
|
super || User.ghost
|
|
end
|
|
|
|
def has_access_to?(project)
|
|
deploy_keys_project_for(project).present?
|
|
end
|
|
|
|
def can_push_to?(project)
|
|
!!deploy_keys_project_for(project)&.can_push?
|
|
end
|
|
|
|
def deploy_keys_project_for(project)
|
|
deploy_keys_projects.find_by(project: project)
|
|
end
|
|
|
|
def projects_with_write_access
|
|
Project.with_route.where(id: deploy_keys_projects.with_write_access.select(:project_id))
|
|
end
|
|
end
|