5db229fb45
Previously, only group masters could do this. However, project reporters can manage project labels, so there doesn't seem to be any need to restrict group labels further. Also, save a query or two by getting a single GroupMember object to find out if the user is a master or not.
201 lines
5.1 KiB
Ruby
201 lines
5.1 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe GroupPolicy, models: true do
|
|
let(:guest) { create(:user) }
|
|
let(:reporter) { create(:user) }
|
|
let(:developer) { create(:user) }
|
|
let(:master) { create(:user) }
|
|
let(:owner) { create(:user) }
|
|
let(:admin) { create(:admin) }
|
|
let(:group) { create(:group) }
|
|
|
|
let(:reporter_permissions) { [:admin_label] }
|
|
|
|
let(:master_permissions) do
|
|
[
|
|
:create_projects,
|
|
:admin_milestones
|
|
]
|
|
end
|
|
|
|
let(:owner_permissions) do
|
|
[
|
|
:admin_group,
|
|
:admin_namespace,
|
|
:admin_group_member,
|
|
:change_visibility_level,
|
|
:create_subgroup
|
|
]
|
|
end
|
|
|
|
before do
|
|
group.add_guest(guest)
|
|
group.add_reporter(reporter)
|
|
group.add_developer(developer)
|
|
group.add_master(master)
|
|
group.add_owner(owner)
|
|
end
|
|
|
|
subject { described_class.abilities(current_user, group).to_set }
|
|
|
|
context 'with no user' do
|
|
let(:current_user) { nil }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.not_to include(*reporter_permissions)
|
|
is_expected.not_to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'guests' do
|
|
let(:current_user) { guest }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.not_to include(*reporter_permissions)
|
|
is_expected.not_to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.not_to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'developer' do
|
|
let(:current_user) { developer }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.not_to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'master' do
|
|
let(:current_user) { master }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'owner' do
|
|
let(:current_user) { owner }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.to include(*master_permissions)
|
|
is_expected.to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'admin' do
|
|
let(:current_user) { admin }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.to include(*master_permissions)
|
|
is_expected.to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
describe 'private nested group use the highest access level from the group and inherited permissions', :nested_groups do
|
|
let(:nested_group) { create(:group, :private, parent: group) }
|
|
|
|
before do
|
|
nested_group.add_guest(guest)
|
|
nested_group.add_guest(reporter)
|
|
nested_group.add_guest(developer)
|
|
nested_group.add_guest(master)
|
|
|
|
group.owners.destroy_all
|
|
|
|
group.add_guest(owner)
|
|
nested_group.add_owner(owner)
|
|
end
|
|
|
|
subject { described_class.abilities(current_user, nested_group).to_set }
|
|
|
|
context 'with no user' do
|
|
let(:current_user) { nil }
|
|
|
|
it do
|
|
is_expected.not_to include(:read_group)
|
|
is_expected.not_to include(*reporter_permissions)
|
|
is_expected.not_to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'guests' do
|
|
let(:current_user) { guest }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.not_to include(*reporter_permissions)
|
|
is_expected.not_to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'reporter' do
|
|
let(:current_user) { reporter }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.not_to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'developer' do
|
|
let(:current_user) { developer }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.not_to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'master' do
|
|
let(:current_user) { master }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.to include(*master_permissions)
|
|
is_expected.not_to include(*owner_permissions)
|
|
end
|
|
end
|
|
|
|
context 'owner' do
|
|
let(:current_user) { owner }
|
|
|
|
it do
|
|
is_expected.to include(:read_group)
|
|
is_expected.to include(*reporter_permissions)
|
|
is_expected.to include(*master_permissions)
|
|
is_expected.to include(*owner_permissions)
|
|
end
|
|
end
|
|
end
|
|
end
|